gilday / dark-mode-sync-plugin Goto Github PK

OS: Windows 10 Pro 1909 build 18363.720
IDE: PhpStorm 2020.1.1
Plugin version: 1.2.2

Note that the behavior doesn't always occur, but when it does - I can't seem to be able to get the whole IDE to be recolored.

Thank you for the nice plugin @gilday
Can you please release version that is compatible with 2020.1 EAP1

The macOS Dark Mode Sync (id=com.github.gilday.darkmode, path=~/Library/Application Support/JetBrains/Toolbox/apps/Rider/ch-1/201.5616.21/Rider EAP.app.plugins/dark-mode-sync-plugin, version=1.1.0) plugin is incompatible (target build range is 192 to 193.*).

This plugin only works on macOS, so it would be nice to restrict its installation to only IDEs running on macOS.

This is not currently possible. See https://youtrack.jetbrains.com/issue/IJSDK-578

When the OS switches between light/dark modes, most of the UI updates but if the Annotations are open (showing e.g. git blame) that pane does not change colors.

Workaround: Closing and reopening the pane fixes this.

Hi, @gilday

Thanks for the great plugin!

I found 2 issues:

1. The menu option shows infinite progress.
2. The theme doesn't changes automatically after restarting the macOS or turning on the device. It changes automatically only if I change the theme in the macOS settings.

Dark Mode Sync v.1.1.0
Android Studio 3.6.2
macOS Catalina 10.15.1

Hey,
it would be great to be possible to customize theme for both modes via some kind of a drop down.

when manually changing the theme is no such problem

Looking at the theme switchiing looks like there's a delay. Looking at the code looks like the refresh rate is 3 seconds.

Looks like other apps are doing it instantly (this is the difference) and it looks kind of laggy. Is there any way we could have it switching as quickly as other apps or is it nor possible?

Thanks!

After update this error is thrown on startup:

Plugin error: Plugin 'Dark Mode Sync' (version '1.2.6') is not compatible with the current version of the IDE, because it requires build 202.* or older but the current build is RD-211.7442.29

Will there be a release to resolve this?

Thank you, love this tool!

Hi there!

Thank you for this plugin, it has been working great so far.

Recently, it has stopped working with Goland (IntelliJ based Golang IDE)

Goland Version: GoLand 2020.3
Build #GO-203.5981.98, built on November 24, 2020

Would it be possible to add support for 2020.3+ versions? I assume it would be similar to this PR? #21

An option to be able to override default color scheme for a theme that is set for day/night modes. Currently, the default color scheme for a theme is set when the theme is changed (synced).

If I enable this plugin on Android Studio 4.1 beta 1, the plugin crashes immediately when the IDE is opened. Here's the stack:

Plugin 'com.github.gilday.darkmode' failed to initialize and will be disabled.  Please restart Android Studio.

java.lang.UnsupportedClassVersionError: com/github/gilday/darkmode/DarkModeSync has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:757)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:636)
    at com.intellij.util.lang.UrlClassLoader._defineClass(UrlClassLoader.java:380)
    at com.intellij.util.lang.UrlClassLoader.defineClass(UrlClassLoader.java:376)
    at com.intellij.util.lang.UrlClassLoader._findClass(UrlClassLoader.java:340)
    at com.intellij.ide.plugins.cl.PluginClassLoader.loadClassInsideSelf(PluginClassLoader.java:259)
    at com.intellij.ide.plugins.cl.PluginClassLoader.tryLoadingClass(PluginClassLoader.java:205)
    at com.intellij.ide.plugins.cl.PluginClassLoader.loadClass(PluginClassLoader.java:113)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Class.java:348)
    at com.intellij.serviceContainer.ComponentManagerImpl.registerComponent(ComponentManagerImpl.kt:288)
    at com.intellij.serviceContainer.ComponentManagerImpl.registerComponents(ComponentManagerImpl.kt:194)
    at com.intellij.serviceContainer.ComponentManagerImpl.registerComponents(ComponentManagerImpl.kt:157)
    at com.intellij.idea.ApplicationLoader$registerAppComponents$1.apply(ApplicationLoader.kt:93)
    at com.intellij.idea.ApplicationLoader$registerAppComponents$1.apply(ApplicationLoader.kt)
    at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616)
    at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591)
    at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
    at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
    at com.intellij.idea.ApplicationLoader$initApplication$2.accept(ApplicationLoader.kt:379)
    at com.intellij.idea.ApplicationLoader$initApplication$2.accept(ApplicationLoader.kt)
    at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774)
    at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750)
    at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
    at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1609)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)

It works fine on Android Studio 4.0.

When the plugin is enabled, I cannot change the light theme to something other than IntelliJ Light. However, I'd like to set it to macos Light. Is there a way to specify which light and dark themes are automatically selected by the plugin?

I was reading JetBrain's blog post today on IntelliJ IDEA 2020.3 EAP which covers some of the features coming to the next release.

One of the features highlighted in this post is IDE theme synced with OS settings which seems to natively bring to IJ the feature this plugin brings.

I was just curious what this means for the Dark Mode Sync plugin. Will this be kept around to continue to bring the feature / functionality to older versions of IJ / other IDEs?

First thanks for this plugin its working great. I would also like to use this plugin on my Linux machine. At least an integration with Gnome 3 based desktop environments would be nice for me.

Could we make this happen? I'm not so familiar with Java anymore but maybe some other Linux user is?

First of all thank you for the great work on this plugin, but unfortunately it seems that it is not working when Auto Mode is enabled in MacOS Catalina.

Maybe this could help
https://forums.developer.apple.com/thread/118974

The latest version of JetBrains IDEs (2020.3) is no longer compatible with Dark Mode Sync: this has cropped up before. Is there an easy way to update this for the latest versions of the IDEs?

Thanks!

-Steve

Currently the plugin seems the ignore the "Use dark window headers" setting.

As you can see in the screenshot, new opened windows reflect the desired setting. But previously opened windows keep whatever was set when the IDE started, leading to either a) Light theme with dark title bar; or B) Dark theme with light title bar.

It takes either restarting the IDE or closing the window for the title bar to appear correctly.

I believe the plugin could be missing reading and/or updating registry setting ide.mac.allowDarkWindowDecorations, but I can't be sure (not familiar with the plugin SDK).

To reproduce the issue just enable the setting and try switching Dark Mode back and forth.