Suggestion: Move Print Debug to Run() functions? about gin HOT 7 OPEN

package main

import (
        "fmt"
        "os"
        "github.com/gin-gonic/gin"
)

func main() {
        os.Setenv("GIN_MODE", "release")
        g := gin.New()
        gin.SetMode(gin.ReleaseMode)
        g.Run(":9000")
        fmt.Println("running")
}

if you insert os.Setenv("GIN_MODE", "release") one line or

Enter environment variables export GIN_MODE=release in command line before go run main.go

you get Expected result

from gin.

I think a new Gin instance has been New and should be set up around it
like this:

package main

import (
	"fmt"

	"github.com/gin-gonic/gin"
)

func main() {
	g1 := gin.New()
	g1.SetMode(gin.ReleaseMode)
	g1.Run(":9001")

	g2 := gin.New()
	g2.SetMode(gin.DebugMode)
	g2.Run(":9002")
	fmt.Println("running")
}

from gin.

I think a new Gin instance has been New and should be set up around it like this:

package main

import (
	"fmt"

	"github.com/gin-gonic/gin"
)

func main() {
	g1 := gin.New()
	g1.SetMode(gin.ReleaseMode)
	g1.Run(":9001")

	g2 := gin.New()
	g2.SetMode(gin.DebugMode)
	g2.Run(":9002")
	fmt.Println("running")
}

1. Gin Mode is a global variable in the package, it isn’t a per instance setting. The gin.Engine doesn’t have a method SetMode
2. Let’s say mode was per instance, the way your code is, both instances would print the debug warning even though the first one you’re running in release mode
   @FarmerChillax

Unless you're saying, what you put with g2.SetMode is how you THINK it should be. If so, I could get behind that.

from gin.

I think a new Gin instance has been New and should be set up around it like this:

package main

import (
	"fmt"

	"github.com/gin-gonic/gin"
)

func main() {
	g1 := gin.New()
	g1.SetMode(gin.ReleaseMode)
	g1.Run(":9001")

	g2 := gin.New()
	g2.SetMode(gin.DebugMode)
	g2.Run(":9002")
	fmt.Println("running")
}

1. Gin Mode is a global variable in the package, it isn’t a per instance setting. The gin.Engine doesn’t have a method SetMode
2. Let’s say mode was per instance, the way your code is, both instances would print the debug warning even though the first one you’re running in release mode
   @FarmerChillax

Unless you're saying, what you put with g2.SetMode is how you THINK it should be. If so, I could get behind that.

The point I'm making is just that it's confusing to use the current API and it feels more natural to set up each instance.(for discussion purposes)

Regardless of current usage.（Maybe I should open a new issue）

from gin.

I think a new Gin instance has been New and should be set up around it like this:

package main

import (
	"fmt"

	"github.com/gin-gonic/gin"
)

func main() {
	g1 := gin.New()
	g1.SetMode(gin.ReleaseMode)
	g1.Run(":9001")

	g2 := gin.New()
	g2.SetMode(gin.DebugMode)
	g2.Run(":9002")
	fmt.Println("running")
}

1. Gin Mode is a global variable in the package, it isn’t a per instance setting. The gin.Engine doesn’t have a method SetMode
2. Let’s say mode was per instance, the way your code is, both instances would print the debug warning even though the first one you’re running in release mode
   @FarmerChillax

Unless you're saying, what you put with g2.SetMode is how you THINK it should be. If so, I could get behind that.

The point I'm making is just that it's confusing to use the current API and it feels more natural to set up each instance.(for discussion purposes)

Regardless of current usage.（Maybe I should open a new issue）

Alright, yeah then you're further proving my point that it isnt so straight forward. Cause even in your suggested design, you would still get the Debug mention when you do g1 := gin.New() because the Gin MOde is declared after, which isnt what one would expect (At least isnt waht I would expect)

I think that debug warning shouldnt be called until the gin server is actually called upon to ListenAndServe. I can also see a value in it being on a per instance basis like you're suggesting as well.

from gin.

I think a new Gin instance has been New and should be set up around it like this:

package main

import (
	"fmt"

	"github.com/gin-gonic/gin"
)

func main() {
	g1 := gin.New()
	g1.SetMode(gin.ReleaseMode)
	g1.Run(":9001")

	g2 := gin.New()
	g2.SetMode(gin.DebugMode)
	g2.Run(":9002")
	fmt.Println("running")
}

1. Gin Mode is a global variable in the package, it isn’t a per instance setting. The gin.Engine doesn’t have a method SetMode
2. Let’s say mode was per instance, the way your code is, both instances would print the debug warning even though the first one you’re running in release mode
   @FarmerChillax

Unless you're saying, what you put with g2.SetMode is how you THINK it should be. If so, I could get behind that.

The point I'm making is just that it's confusing to use the current API and it feels more natural to set up each instance.(for discussion purposes)
Regardless of current usage.（Maybe I should open a new issue）

Alright, yeah then you're further proving my point that it isnt so straight forward. Cause even in your suggested design, you would still get the Debug mention when you do g1 := gin.New() because the Gin MOde is declared after, which isnt what one would expect (At least isnt waht I would expect)

I think that debug warning shouldnt be called until the gin server is actually called upon to ListenAndServe. I can also see a value in it being on a per instance basis like you're suggesting as well.

Yes, I agree with your point too. I hope that while improving the API, I will also correct the debug information you mentioned.

from gin.