Comments (4)
from dans-gdal-scripts.
Thanks for the thorough review. I'm aware more work would need to be done for a full merge.
The Visual Studio files are an okay example of how to do it. I was using those in conjunction with prebuilt binaries from http://www.gisinternals.com/ . A lot of modern projects have switched from autoconf to CMake because CMake will generate Visual Studio build files on demand. Using CMake would allow us to leave the Visual Studio project files out of the repository.
I wasn't sure what to do on the config.h reference. I suppose I could have done something like wrap it in #ifndef _WINDOWS...
I had intended to use std::stoi
, not the old stdlib version. The newer conversion methods do throw errors on malformatted input. I was concerned about getting the right version of Boost to match whatever GISinternals used on their build, which wasn't obvious. It seemed easier to just ditch it. It might be nice, though, to utilize newer build chain features for referencing individual Boost features straight from Github -- some kind of auto external dependency.
On the alpha, I did wonder if any alpha meant "keep it". I also wondered if 50% was a good cutoff. A zero alpha threshold would probably work fine in all me test data.
Concerning simultaneous NDV entries, I had expected that your code would OR them. You're saying it's an AND, so my logic there is definitely not quite right.
from dans-gdal-scripts.
from dans-gdal-scripts.
Adding an update that I no longer use the MS Build files in my branch. For Windows, I compile things directly with a call like this one:
cl.exe /MD /O2 /EHsc /Fe:gdal_trace_outline /DNDEBUG /D_CONSOLE ^
src\beveler.cc src\common.cc src\datatype_conversion.cc src\debugplot.cc src\dp.cc ^
src\excursion_pincher2.cc src\gdal_trace_outline.cc src\georef.cc src\mask-tracer.cc ^
src\mask.cc src\ndv.cc src\palette.cc src\polygon-rasterizer.cc src\polygon.cc ^
src\raster_features.cc src\rectangle_finder.cc ^
/I..\gdal\gdal\ogr /I..\gdal\gdal\port /I..\gdal\gdal\gcore /I..\gdal\gdal\ogr\ogrsf_frmts ^
/link ..\gdal\gdal\gdal_i.lib
from dans-gdal-scripts.
Related Issues (16)
- Building the tool to work with GDAL 2.1.3 HOT 1
- calculate alpha channel directly in gdal_trace_outline HOT 1
- A bug of destructor of BboxBinarySpacePartition class? HOT 1
- Parameter --quiet HOT 1
- Error during installation HOT 2
- GDAL v3 breaking changes HOT 2
- gdal_trace_outline producing incorrect results HOT 1
- Some extra steps to install scripts on MacOS HOT 1
- Smooth edges on gdal_trace_outline HOT 1
- Unknown conversion type character 'z' in format HOT 5
- Report invalid options in gdal_landsat_pansharp
- How to install it on a Linux instance of Amazon EC2? HOT 1
- Usage info for gdal_contrast_stretch HOT 1
- Serious bug in gdal_trace_outline (produces broken geometry) HOT 7
- request for gdal_trace_outline.cc HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dans-gdal-scripts.