Giter VIP home page Giter VIP logo

Comments (4)

davvid avatar davvid commented on May 26, 2024

Sweet. Yup, we need to use a console. I'll take a look at your patch shortly. Thanks for the help. I wasn't sure how to do it portably (cross-platform) so I deferred implementing that part up front.

from git-cola.

davvid avatar davvid commented on May 26, 2024

Your patch implements its own console. Very nice. From a quick read it looks good.

The only issue is that we're calling out to GUi code directly from a command object. That's easily to refactor and I can take care of it now that you've done the heavy lifting.

We have the prompt_user() thing for interacting with UI components from command objects. I'll register a handler for it so that we can get the desired behavior.

That should let us pass the parent widget pointer in too so that we can wait for the dialog to finish before calling rescan.

Thanks! good stuff.

from git-cola.

davvid avatar davvid commented on May 26, 2024

Oh ya.. I'll be able to work on this as soon as I finish my taxes ;-)
Soon, but probably not until this weekend/next week.

Thanks for your patience.

from git-cola.

davvid avatar davvid commented on May 26, 2024

Ok, I applied your patch (added a sign-off, I hope that's ok) and then tweaked things a bit. It supports unicode now :-) and does the correct rescan thing as described in git-config(1).

from git-cola.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.