Comments (4)
Sweet. Yup, we need to use a console. I'll take a look at your patch shortly. Thanks for the help. I wasn't sure how to do it portably (cross-platform) so I deferred implementing that part up front.
from git-cola.
Your patch implements its own console. Very nice. From a quick read it looks good.
The only issue is that we're calling out to GUi code directly from a command object. That's easily to refactor and I can take care of it now that you've done the heavy lifting.
We have the prompt_user() thing for interacting with UI components from command objects. I'll register a handler for it so that we can get the desired behavior.
That should let us pass the parent widget pointer in too so that we can wait for the dialog to finish before calling rescan.
Thanks! good stuff.
from git-cola.
Oh ya.. I'll be able to work on this as soon as I finish my taxes ;-)
Soon, but probably not until this weekend/next week.
Thanks for your patience.
from git-cola.
Ok, I applied your patch (added a sign-off, I hope that's ok) and then tweaked things a bit. It supports unicode now :-) and does the correct rescan thing as described in git-config(1).
from git-cola.
Related Issues (20)
- Checkout branch dropdown re-drops after selcting branch HOT 1
- unintuitive context menu option(s) HOT 2
- Suppress "Remote Messages" Popups HOT 2
- documentation request: can the Linux installation instructions be improved? HOT 1
- Request: A tar release HOT 2
- The title bar (or something else) should show the name of the file currently selected HOT 1
- Wrong name for toolbar tool HOT 5
- How does cola start on Windows? HOT 3
- the commit button randomly becomes blank HOT 6
- sometimes not all files are staged or reverted HOT 5
- Version 4.5.0 Wont start after update HOT 6
- Flatpak install: cannot access pre-commit hooks or launch editor HOT 3
- Feature Req: Stage single lines within a diff hunk HOT 2
- Git-cola crashes when no commit.template is defined HOT 1
- `git-sequence-editor` invoked with wrong path on Windows HOT 10
- git-cola died of signal 11 HOT 9
- Mac Cmd+M (minimize window) is ignored by git-cola and has different action HOT 1
- Commit message input box pre-filled at startup HOT 2
- Ignoring a file locally fails if within a worktree HOT 2
- Programmatically change the UI theme? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-cola.