github-actions-tools / gh-reviews-count Goto Github PK

Not an issue, but rather a suggestion.

The default for pull_number isn't a very common use-case. Proposing to change the default to github.event.number or github.event.pull_request.number

I use the action in a workflow triggered on pull request events, which I would guess is the most common use-case. For those events github.event.issue.number has no value resulting in 404. github.event.number works for my events and would cover most of the common use-cases.

These two deprecated support will be removed soon by Github :

• node 12 version: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
• set-output command : https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I've opened a PR to resolve this : #4

Hi,

With making some tests with only 2 Github accounts (1 for opening the PR, 1 for reviewing it), and playing with approve/request changes in the same PR, I faced these counts in workflows :

My use case is to run conditional steps depending on the current PR status (approved/changes_requested). Unfortunately, these calculated counts are not relevant nor exploitable 😢

Is it possible to increment/decrement these counts to have the real current PR status ?