gittymac / openfk Goto Github PK

I've noticed some people still manage to find older versions of OpenFK and FSGUI, back when it was called FunkeySelector.
The version of OpenFK doesn't seem too old because it still auto-updates, but FSGUI doesn't, because the older version is named FunkeySelector.exe and not FunkeySelectorGUI.exe, which is what OpenFK checks for.

We should ensure the following is dealt with:

• A missing fsguiupdate.xml
• Older FunkeySelector.exe
• Where people keep finding these old downloads

Some settings in the ConfigForm (the checkbox ones) save every time its check changes state.

This can be pretty confusing to the user, as the Save and close button implies nothing is saved until that button is pressed.

Should I fix this or is this confusing behavior intentional?

I just looked at the broken things, realizing the rdf loading is broken.
Why is it broken?
Or is it just not implemented yet?
I can help translating the rdf util if you want from java to c#.

As described in #7.
This is a separate issue because we first need to make some changes so we can use the update feature here.

There are many cases where the difference between 64-bit and 32-bit might cause issues.
An example:
A user on a 64-bit computer could have accidentally downloaded a 32-bit version of OpenFK and fetchOCX assumed it needed to download a 64-bit OCX, causing a crash or other weird issues.

This shows that fetchOCX is inherently flawed and needs more checks, which I would move into OpenFK itself.

Firstly, we should change OpenFK itself to handle downloading update.msu since we should not be relying on a user having Powershell installed. It feels wrong to create compatibility issues with older versions of Windows like this when it can be avoided.
After OpenFK has downloaded update.msu and created the tempdl folder, we let fetchOCX extract the files.
Then OpenFK takes over, copies the OCX it needs, and deletes tempdl and FetchOCX.bat.

OpenFK should also warn the user if they are running a 64-bit system and running the 32-bit version before downloading any OCX file.
I think we could make use of the update feature to redownload the correct version of OpenFK to automatically fix this.