gkawka / geckoboard-dataset-api Goto Github PK

Goal

Repo has tests for all available PHP versions ("^5.3"). We can use Travis-ci for open-source repositiories.

Bug example

I found possible bug in DataBuiilder implementation where is using declaration from higher PHP version.

Hey man, Would be great if you could tag another release since you've changed the composer.json php version to allow PHP 7.

Would mean I can avoid doing this in our composer.json:

"gkawka/geckoboard-dataset-api": "dev-master#7ad902974ddf2c65866c0c2690c9df8de6334cd9"

If I don't use dev-master I get:

    - kwk/geckoboard-dataset-api 0.1.5 requires php ^5.3 -> your PHP version (7.0.22) does not satisfy that requirement.

No license means implicit copyright. Consider adding a permissive license, such as MIT, BSD or Apache. This may be helpful when making the choice: https://tldrlegal.com/

Goal

Readme has an example of using append datarow

Goal

TypeInterface contains information on field identifier. It simplifies API on DatasetBuilder by remove id parameter on addField() method

Example

interface TypeInterface
{
    // ...

    /**
     * Return type identifier
     *
     * @return string
     */
    public function getName();
}

class DatasetBuilder
{
    // ...

    public function addField(TypeInterface $fieldDefinition)
    {
        $this->fields[$fieldDefinition->getName()] = $fieldDefinition->toArray();

        return $this;
    }