glasswalk3r / archive-tar-wrapper-perl Goto Github PK
View Code? Open in Web Editor NEWThis project forked from mschilli/archive-tar-wrapper-perl
Archive::Tar::Wrapper CPAN Module
License: GNU General Public License v3.0
archive-tar-wrapper-perl's People
Contributors
Stargazers
Watchers
archive-tar-wrapper-perl's Issues
Test::Simple should not be a runtime dependency
With the release of 0.27, Test::Simple is a runtime dependency. This is particularly an issue for us as it pulls in Test2, which our test runner is not yet compatible with.
Test suite fails on NetBSD
See http://matrix.cpantesters.org/?dist=Archive-Tar-Wrapper%200.37 for an overview of CPAN Testers reports — at the time of writing there are only fail reports on the NetBSD platform.
no recent Changes entries
There are no Changes entries for the 0.27, 0.28 or 0.29 releases.
Minor licensing inconsistency
| File | Indicated License |
|---|---|
| LICENSE | GPL-3 |
| lib/Archive/Tar/Wrapper.pm | GPL-3+ |
| Makefile.PL | GPL-3 |
| eg/tarflat | perl |
| META.yml | gpl |
| README.md | GPL-3+ |
| META.json | GPL-3 |
The biggest outlier here being eg/tarflat
archive-tar-wrapper-perl/eg/tarflat
Lines 89 to 98 in e93747f
It may not be legally viable to fix this or whatever, but I thought I'd just raise this in case the situation can be improved.
Tarball produced by Archive::Tar::Wrapper + GNU tar 1.23 is not readable by HP-UX tar
It was reported by me that one of my tarball dists was not readable by the default HP-UX tar because GNU tar 1.23 uses defaults that do not work with tar implementations that do not support GNU extensions.
One way to work around this is to use Archive::Tar instead, but there isn't a way to disable Archive::Tar::Wrapper (as far as I can tell) if it happens to be installed.
I am not sure how hard it would be, but it would be nice if Archive::Tar::Wrapper could either
- Detect GNU tar (looks like it might already be doing this) and use the
--format=ustaroption to produce a more backward compatible tarball. - Provide an option to explicitly do the same.
unnecessary dependency Dumbbench
Dumbbench doesn't install cleanly on more recent perls; could this dependency be removed? I would suggest moving t/008performance.t to xt/ so it doesn't run for normal installations.
Test suite fails if bzip2 is not installed
On a very minimal debian/jessie system running in a docker container:
2018/07/09 18:35:52 /bin/tar jx -f /root/.cpan/build/Archive-Tar-Wrapper-0.31-NMaTJ4/t/data/foo.tar.bz2 failed: tar (child): bzip2: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
/bin/tar: Child returned status 2
/bin/tar: Error is not recoverable: exiting now
# Failed test 'opening compressed tarfile'
# at t/007bzip.t line 17.
# Failed test 'find 001Basic.t'
# at t/007bzip.t line 19.
# Failed test 'find ./001Basic.t'
# at t/007bzip.t line 20.
# Looks like you failed 3 tests of 5.
t/007bzip.t ......
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/5 subtests
The Dockerfile looked like this:
# docker build -t perl-test . && docker run perl-test
FROM debian:jessie
RUN apt-get -y update
RUN apt-get -y install perl-modules
RUN apt-get -y install make
CMD cpan -t ARFREITAS/Archive-Tar-Wrapper-0.31.tar.gz
Confusing license
Hi,
Your README says 'same license as perl' but you added a GPL-3, which is not as perl itself. Your license in MakeMaker says 'gpl', which is not even an option in http://search.cpan.org/~dagolden/CPAN-Meta-2.150010/lib/CPAN/Meta/Spec.pm#license
Please make up your mind, you're making it hard for distributions to clarify your intentions.
Undeclared dependency Dumbbench (0.32)
The test suite fails if Dumbbench.pm is not installed:
Can't locate Dumbbench.pm in @INC (you may need to install the Dumbbench module) (@INC contains: t/lib /home/cpansand/.cpan/build/2018071012/Archive-Tar-Wrapper-0.32-0/blib/lib /home/cpansand/.cpan/build/2018071012/Archive-Tar-Wrapper-0.32-0/blib/arch /usr/perl5.26.1p/lib/site_perl/5.26.1/amd64-freebsd /usr/perl5.26.1p/lib/site_perl/5.26.1 /usr/perl5.26.1p/lib/5.26.1/amd64-freebsd /usr/perl5.26.1p/lib/5.26.1 .) at /usr/perl5.26.1p/lib/5.26.1/parent.pm line 16.
BEGIN failed--compilation aborted at t/lib/ATWDumbbench.pm line 4.
Compilation failed in require at t/008performance.t line 6.
BEGIN failed--compilation aborted at t/008performance.t line 6.
# Looks like your test exited with 2 before it could output anything.
t/008performance.t ........
Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/1 subtests
Can't locate Dumbbench.pm in @INC (you may need to install the Dumbbench module) (@INC contains: t/lib /home/cpansand/.cpan/build/2018071012/Archive-Tar-Wrapper-0.32-0/blib/lib /home/cpansand/.cpan/build/2018071012/Archive-Tar-Wrapper-0.32-0/blib/arch /usr/perl5.26.1p/lib/site_perl/5.26.1/amd64-freebsd /usr/perl5.26.1p/lib/site_perl/5.26.1 /usr/perl5.26.1p/lib/5.26.1/amd64-freebsd /usr/perl5.26.1p/lib/5.26.1 .) at /usr/perl5.26.1p/lib/5.26.1/parent.pm line 16.
BEGIN failed--compilation aborted at t/lib/ATWDumbbench.pm line 4.
Compilation failed in require at t/009performance-small.t line 6.
BEGIN failed--compilation aborted at t/009performance-small.t line 6.
# Looks like your test exited with 2 before it could output anything.
t/009performance-small.t ..
Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/1 subtests
Also it seems that a minimum version of Dumbbench is required. On some of my smokers:
Undefined subroutine &Dumbbench::unscientific_notation called at t/lib/ATWDumbbench.pm line 34.
# Looks like your test exited with 25 before it could output anything.
t/008performance.t ........
Dubious, test returned 25 (wstat 6400, 0x1900)
Failed 1/1 subtests
list_all output has changed
Hi there
It looks like tar_path that is returned for each item in list_all is now prefixed by tar/. Is that expected to stay going forward?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.