glazastik / dominion Goto Github PK

If we want to save the settings in Settings with PrintWriter we need to exit with the exit() method in MainView.

Right now we exit with sbg.getContainer.exit() which is not the same...

InGameState is running the risk of becoming a god object. Or at least I feel so. A lot of code in one class anyway. We should probably take care, or even action. May not be doable since this state contains so much gamecode, but if this class can somehow be shrunk, I believe it to be worthwhile.

When you leave ShowCardState, any click you make is registered in the state you enter, which is InGameState. This causes clicks on areas where cards are, a majority of the board, to be registered as clicks on them. This is problematic since this is not the intention when you are in ShowCardState, and will result in unwanted behaviour down the road. Not high priority, but must be fixed before game is shipped.

mouseClicked smells, and it smells bad. There's too much logic contained within, but due to the programs nature this method needs to be called every update and a lot of things has to be checked. This method needs to be refactored somehow, and anyone is free to clean it up, although I will take main responsibility for it.