gliscowo / deathlog Goto Github PK

Hello!

For moderation purposes, I would like to suggest a way to restore another player's death entry into my own inventory intead of theirs.

Usage for this would be: If a player loses a certain item(s) due to a server crash, being able to give that item(s) back without restoring the whole death entry into their inventory

Currently, the latest version of the mod crashes when starting the 1.19.1 server.

The game window did't open while Java was running. I changed Deaths from 30 to 29 and the client could start. Deaths.dat contained 30 deaths but two same deaths connected without a seperator. The extra death was attributed to DeathFinder.
Minecraft 1.20, Fabric loader 0.14.21, Fabric api 0.83.0, Owo lib 0.11.0, Deathlog 0.3.2, DeathFinder 7.0.0.

It seems like on certain server, there are custom entities with long names, which if you getting killed by one, it would display the death cause like below:

it just dosent launch no log, no nothing. 1.20.1 fabric, running on m1 mac

So the server I'm playing has custom death message plugin called DeathMessage

I don't really sure if any servers using this as well, but I would love to see this mod supports "custom death messages"

Since it doesn't supports, the death message is now blank, kinda "useless" for knowing what/who killed you

If it's not possible then alright at least worth the suggestion 👀

Version 1.19.2 fabric
0.2.11
Problem
Stalls server by "Simply one of the mods is somewhere serializing too much stuff and it bricks "
Prevents server full start up
Will
crash-2023-02-11_05.30.42-server.txt

Hello!
Developer of Better Statistics Screen here.

Recently, there's been interest in integrating my mod with DeathLog (Examples include: Issue 13, and recently Issue 108). While I'm eager to make this happen, the current lack of an API presents a challenge.

As such, I would like to suggest for this mod to implement some sort of reliable way for other mods to integrate this mod, such as a simple API. Here is an example of how ModMenu implements their API.

Here is an example of what you could do:

package com.glisco.deathlog.api.client;

import net.minecraft.text.Text;
import net.minecraft.client.gui.screen.Screen;

public interface DeathLogClientApi
{
    static Screen createDeathLogScreen(@Nullable Screen parent) {...}
    static Text createDeathLogButtonText() {...}
}

...kind of like how ModMenu does it for their mod. Other mod developers such as myself, could then implement support for your mod through CurseMaven and your API.

If implementing your own API isn't feasible, I'd like to present an alternative. My mod, Better Statistics Screen, features an API that allows other mods to integrate custom elements. While this would necessitate a dependency, it's a potential workaround. Although, you would have to add betterstats and tcdcommons to the Gradle proejct, and based on the issue #30, I am assuming you implementing support is likely not what you'd want.

Thank you for your time, as that's all I wanted to suggest, and have a great day!

AOF5 modpack 1.2.3 deathlog 0.2.9+1.18 maybe its already fixed in newer version

java.lang.NullPointerException: Cannot read field "screenshotsEnabled" because the return value of "com.glisco.deathlog.client.Config.instance()" is null
	at com.glisco.deathlog.client.gui.DeathLogScreen.createScreenshotButtonText(DeathLogScreen.java:72)
	at com.glisco.deathlog.client.gui.DeathLogScreen.method_25426(DeathLogScreen.java:62)
	at net.minecraft.class_437.redirect$fij000$onInit(class_437.java:8790)
	at net.minecraft.class_437.method_25423(class_437.java:389)
	at net.minecraft.class_310.method_1507(class_310.java:993)
	at com.glisco.deathlog.client.DeathLogClient.openScreen(DeathLogClient.java:57)
	at com.glisco.deathlog.client.DeathLogClient.openScreen(DeathLogClient.java:52)
	at com.glisco.deathlog.client.DeathLogClient.lambda$onInitializeClient$0(DeathLogClient.java:36)
	at net.minecraft.class_4185.method_25306(class_4185.java:40)
	at net.minecraft.class_4264.method_25348(class_4264.java:16)
	at net.minecraft.class_339.method_25402(class_339.java:121)
	at net.minecraft.class_4069.method_25402(class_4069.java:27)
	at net.minecraft.class_312.method_1611(class_312.java:94)
	at net.minecraft.class_437.method_25412(class_437.java:492)
	at net.minecraft.class_312.method_1601(class_312.java:94)
	at net.minecraft.class_312.method_22686(class_312.java:165)
	at net.minecraft.class_1255.execute(class_1255.java:103)
	at net.minecraft.class_312.method_22684(class_312.java:165)
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36)
	at org.lwjgl.system.JNI.invokeV(Native Method)
	at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101)
	at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:197)
	at net.minecraft.class_1041.method_15998(class_1041.java:310)
	at net.minecraft.class_310.method_1523(class_310.java:1147)
	at net.minecraft.class_310.method_1514(class_310.java:737)
	at net.minecraft.client.main.Main.main(Main.java:236)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:460)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

server-crash

This occurs on startup (right before the game finishes launching) after having used and then removing Trinkets.

add something like a replay of the last minute before death.

I'm on 1.19 Fabric, I also cant find deathlog.dat
crash-2022-06-24_20.21.35-client.txt
Edit: I cant read and had to delete my deaths.dat file

Travellers Backpacks are not logged by this mod, they are not returned to users when they get their items restored.

Minecraft: 1.20.1
Fabric: 0.14.24
DeathLog: 0.3.2+1.20
Travelers Backpack: 1.20.1-9.1.8

Anytime I Try To Open The Mod It Always Says " An Error Startup Prevented Minecraft From Starting" What Caused It Was Deathlog. I Have Been Trying To Play For A Week Now And Nothing. Any Help?

Can you add that it also makes these snapshots when a player logs out or when the server stops?
Idk if its possible to detect a server crash to backup the inventorys but this would also be cool

Minimum Functionality

Every time a player dies, their inventory is backed up to a database (even if they don't have the client mod). This backup can be viewed by administrators (and admins can also copy individual items from the backup), and they can restore the player's inventory at the click of a button (this would probably overwrite the player's inventory). Their experience (xp) would also be able to be restored.

Extra Features

• Force-backups (admins can force a backup via a command)
• Ability to save to a MySQL database
• LuckPerms etc. support
• Ability to configure non-death events to saves (eg. Dimension change, joins, leaves)
• Ability to limit the amount of backups per player (oldest backups are overwritten)

When I was playing in the survival world and switched to creative I accidentally clicked clear inventory and lost all the stuff, that's why I lost the world :( .Hope you will add such feature :/

Minecraft consistently crashes every time I click "Statistics" when DeathLogger is installed and never without. I don't know which version introduced the issue, but could binary-search that if that's helpful.

crash-2023-02-05_22.08.23-client.txt

I tried all the mouse buttons and lots of the keyboard buttons, all with various modifier keys, in Survival and Creative, with an OP account and the non-OP account that died, nothing works. Seems like this feature is just broken in 0.3.1.

Add death recovery item check mark
what I mean is when you die death log says you had this items and this is the coordinates you lost your items.
now it would be great if when player goes back to the death location and recovers all its items a sound cue or a check mark icon shows in the left side of the experience bar that indicates you recovered all of your lost items on death.(if all items in inventory match or exceed the number on death then should give the recovery signal)
thanks in advance <3

Mods installed for test:

• deathlog-0.2.4+1.18
• fabric-api-0.45.0+1.18
• modmenu-3.0.1
• trinkets-3.1.0

Steps for reproduction:

• connect to dedicated server with deathlog, have op/be in creative
• have inventory and die
• Open death log, and shift-click the restore icon
• Return to game and see inventory is not restored
• Check log
  Expected: will restore like single player
  Actual: does not restore, outputs error in log

Here's the server log: https://pastebin.com/qfAb2QEs

The interface does NOT shrink on the screen. Version 1.18.1.
Could you make the left panel half the width?
My screen resolution is 1280x1024

The Modrinth page displays the mod's client support as 'required' and server support as 'unsupported' despite the README stating that it can be used independently on either.

Better Statistics Screen

I've been meaning to report this issue for… almost a year now, but things kept coming up and I kept forgetting l o l

※ Disclaimer: I haven't actually looked too closely at DeathLog's code to see how it's detecting player deaths, and also most of my Minecraft dev experience lies with server-side Bukkit plugins instead of client-side Fabric/Forge mods.

Description

The current mechanisms of detecting deaths that DeathLog is using (ServerPlayerEntityMixin and ClientPlayNetworkHandlerMixin) do not work with certain types of servers, notably old legacy servers put through some kind of protocol translator, like ViaVersion(ViaFabric)/VIAaaS/ViaProxy.

You can test this by connecting to something like the Glowstone Test Server (mc.glowstone.net, native protocol version 1.12.2), killing yourself, and seeing how DeathLog fails to detect the death event.

This is reproducible across all DeathLog versions from 0.2.10 (1.19.2〜1.19) all the way down to 0.1.2 (1.16.5〜1.16.2).

Proposed solution

I think it would be a good idea to consider adding an additional player death detection mechanism, and OR'ing it (not replacing it, see below as to why) with the current mechanism in order to get around this.

Specifically, since the death screen usually always appears upon death (the only time when it doesn't is if the doImmediateRespawn gamerule is set to true), hooking net.minecraft.client.gui.screens.DeathScreen would probably be a solution for detecting deaths that ServerPlayerEntityMixin fails to detect.

It would also probably be good to add a check for a HealthUpdateS2CPacket sent from the server with a value of 0, since this is another method of triggering deaths used by legacy servers.

It may also be worth taking a look at whatever DeathFinder (MPL2.0-licensed) is doing for its player death detection mechanism, since I know that definitely works for the servers above as I sometimes use it in combination with DeathLog as a workaround to at least get coordinates on the death screen when playing on these kind of servers. ;P (I haven't really looked at their code yet, though.)

Just so this is documented.

I don't fully rely on this mod, but it helps to figure out what to command-give people after they bug-died, so I advertise it everywhere usually. Can't do that if it doesn't work! ;)

Add the possibility to disable logging deaths (and making screenshots) for certain servers.

This would be useful for PvP servers for example.