Giter VIP home page Giter VIP logo

roaring's Issues

the new rangeOfOnes implementation reveals some bugs

when roaringarray.go's func rangeOfOnes(start, last int) container is implemented purely with bitmaps, arrays, or rle16 containers, I see test suite failure. Here are the 3 options:

For context: this

https://github.com/RoaringBitmap/roaring/blob/master/roaringarray.go#L42

is being replaced by:

 func rangeOfOnes(start, last int) container {
       return newBitmapContainerwithRange(start, last) // option 1
       //return newArrayContainerRange(start, last) // option 2
       //return newRunContainer16Range(uint64(start), uint64(last)) // option3
 }

and here are the suite fails, which are different in each case:

bitmaps for runs, test failures:

func TestDoubleAndNotBug01(t *testing.T)  fails, line 1681

Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 1681:
  Expected: true
  Actual:   false

----------

arrays for runs: 2 distinct fails:

Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 1616:
  Expected: 'true'
  Actual:   'false'
  (Should be equal)


--- FAIL: TestDoubleAdd2 (0.01s)

Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 1629:
  Expected: 'true'
  Actual:   'false'
  (Should be equal)



--- FAIL: TestDoubleAdd3 (0.01s)

----------
with rle16:


Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 787:
  Expected: '96617'
  Actual:   '9'
  (Should be equal)



Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 865:
  Expected: '35392'
  Actual:   '1928'
  (Should be equal)

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 886:
  Expected: '131999'
  Actual:   '131351'
  (Should be equal)

Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 933:
  Expected: 'true'
  Actual:   'false'
  (Should be equal)

Failures:

  * /Users/jaten/go/src/github.com/glycerine/roaring/roaring_test.go 
  Line 1589:
  Expected: 'true'
  Actual:   'false'
  (Should be equal)


--- FAIL: TestFlipBigA (0.12s)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.