gmanroney / cryptoboard Goto Github PK

Going to add ability to send exchange name from command line e.g. server.js hitbtc so the same code can run up exchanges independently. For now options will be
server.js -> do nothing
server.js hitbtc -> do hitbtc
server.js bitfinex -> do bitfinex

Send output from server to log file

As of now a websocket is opened for each connection to the exchange. This does not appear to be terribly efficient and needs to be investigated to see if using a single websocket will make the code more efficient.

Refactoring of redis step in each exhange function into its own separate function.

https://docs.bitfinex.com/docs

{
"name": "bitfinex",
"docurl": "https://docs.bitfinex.com/docs",
"wssurl": "wss://api.bitfinex.com/ws",
"pairs": "BTCUSD, LTCUSD, LTCBTC, ETHUSD, ETHBTC, ETCUSD, ETCBTC, BFXUSD, BFXBTC, RRTUSD, RRTBTC, ZECUSD, ZECBTC",
"active": "Y"
}

Document on how to use crpytoboard

Basic function working but it crashes some time after start with the following error:

BITFINEX wss://api.bitfinex.com/ws BTCUSD
BITFINEX wss://api.bitfinex.com/ws LTCUSD
BITFINEX wss://api.bitfinex.com/ws LTCBTC
BITFINEX wss://api.bitfinex.com/ws ETHUSD
BITFINEX wss://api.bitfinex.com/ws ETHBTC
BITFINEX wss://api.bitfinex.com/ws ETCUSD
BITFINEX wss://api.bitfinex.com/ws ETCBTC
BITFINEX wss://api.bitfinex.com/ws BFXUSD
BITFINEX wss://api.bitfinex.com/ws BFXBTC
BITFINEX wss://api.bitfinex.com/ws RRTUSD
BITFINEX wss://api.bitfinex.com/ws RRTBTC
BITFINEX wss://api.bitfinex.com/ws ZECUSD
BITFINEX wss://api.bitfinex.com/ws ZECBTC
Finshed launch
Connected to Redis Server
events.js:160
throw er; // Unhandled 'error' event
^
Error: unexpected server response (429)
at ClientRequest._req.on (/Users/germoroney/Development/cryptoboard/node_modules/ws/lib/WebSocket.js:653:21)
at emitOne (events.js:96:13)
at ClientRequest.emit (events.js:188:7)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:473:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)
at TLSSocket.socketOnData (_http_client.js:362:20)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:176:18)
at TLSSocket.Readable.push (_stream_readable.js:134:10)
[nodemon] app crashed - waiting for file changes before starting...

The number of clients connecting to redis to read data were initially thought to be related but this was found to be misleading. Happens with 1, 2 or 3 clients connecting to REDIS.

Error message found in https://github.com/bitfinexcom/bitfinex-api-node seems to be related to BITFINEX service itself ....

There will be a configuration file for each exchange containing:

• URL for exchange
• URL for exchange documentation
• Name of exchange to be used in redis
• Currency/currencies reported on the exchange

Automated test cases for application

1. Connect to websocket api interface (using native library, if exists);
2. Read JSON-config file with Redis connection settings as list of symbols (symbo usually consist of coin and currenct);
3. Subscribe to trade data on given symbols
4. Push all trades to the Redis to queue named Exchange:Symbol as array of [timestamp, trade_id(if exists), price, amount, side(buy/sell)]
5. Application will reconnect on connection fail and be optimized for speed / throughput.

Identify what channels are active and what are not for a particular exchange

• Enter exchange function
• Open socket stage
• Send request message via socket for symbol
• Response to socket request for symbol (successful/failed)
• List of active and inactive streams from Redis

Refactoring of main function and moving looping through configuration to separate functions

Possibly combining of functions together.

Do we need command line options if we have active = y/n in the configuration file?

Analyse records as subscriber from redis and get:

• Record count by type (buy,sell)
• Total amount of trade (buy,sell)
• Average amount of trade (buy,sell)
• Median amount of trade (buy,sell)
• Delta between total amount bought and sold

This will be part of the client in addition to the record.