gmournos / quicksight-as-code Goto Github PK

Hey George,

Got your ping from the CDK repo issue (aws/aws-cdk#19212 (comment))

Was looking at your code and so far it looks like a really in-depth solution and I am really enjoying studying your approach!

I have one recommendation though. Do not use dynamic (at build time) values like this. Because this will result in a d CloudFormation change, and will always result in an update, on every deployment.

OMG, this is amazing and clever!! Thanks for sharing that. This one paragraph changes so much for me you have no idea!

The QS developer runs script make-template-choice.sh for this analysis, in order to create a template from the updated analysis and to download its definition. At this point, the file e.g. template-defs/sales-template-def.json has changed to reflect the requirement. However, it is cumbersome to locate the actual change because a lot of internal ids of the template also changed. To circumvent this problem, we can instead use file template-defs/review/sales-template-def.json, which is also generated when we run script make-template-choice.sh. This is a projection of the template definition, without these internal ids. Performing a diff on versions of this file, shows the actual change implemented, providing for full transparency and traceability to requirements.

Just a suggestion, nothing wrong with your solution. But a cool solution we developed is to use Step Functions to issue refresh requests. That way you don't need to maintain a Lambda and you get a nice visual log of all the runs, so don't need to even log into CloudWatch. Plus you can do retries, and even build a whole graph of refreshes, if you want, in the right sequence.