Issue when loading Knockout via AMD about editablecell HOT 2 CLOSED

¡Hola!

I made the following changes to the develop branch:

• knockout is now being required internally in editableCell (like you tried), and to prevent it from being included in the bundle, the -x knockout option is passed along to browserify, which required updating browserify to version 2.27.1 to get to work.
• the browserify bundle is getting modified, replacing the AMD top-level define call from define(e) to define(['knockout'], e)
  • this makes RequireJS load knockout as a prerequisite, thus the RequireJS config must define a path for knockout (see index.html).
• to still support the non-AMD, non-CommonJS scenario, instead of directly referencing knockout internally, a wrapper has been added that checks to see if the global ko is available or else calls require('knockout') (AMD).

Also the index.html now uses RequireJS to load everything.

I copied the new editableCell.js into your src/vendor folder and removed the preEditableCell file to confirm, and everything now works just fine when running from both src and dist.

from editablecell.

Cool, thanks!

from editablecell.