Giter VIP home page Giter VIP logo

carpet-extra's People

Contributors

2no2name avatar altrisi avatar crystal0404 avatar deadlymc avatar dragoneggbedrockbreaking avatar fallen-breath avatar fxmorin avatar ghoulboy78 avatar github-actions[bot] avatar gnembon avatar imurx avatar logwet avatar manyrandomthings avatar maruohon avatar meenimc avatar privacypolicy avatar replaceitem avatar salandora avatar supersaiyansubtlety avatar triphora avatar whats2000 avatar whoimt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

carpet-extra's Issues

[REQUEST] Robust bedrock-less wither cages

I'd love an option that fixes some of the issues with bedrock-less wither cages. For example dealing with the wither losing its target when you unload it, as ilmango explains here.

There may be other things that could be done to make wither cages less fragile, but I'm no expert.

[Bug] "repeaterPriorityFix" brings unwanted issues

After several tests, I found that this feature does not work properly. It does fix MC-54711, but it brings some unwanted issues.

For instance, the following contraption becomes directional
repeaterPriorityFix1

To further investigate, I built the following contraption:
repeaterPriorityFix2

The result was expected:
repeaterPriorityFix3

But when I placed another repeater behind the one on the right, the result became interesting:
repeaterPriorityFix4

So I infer that this patch makes repeaters (and comparators perhaps) decide their priority according to the block behind them intead of the block in front of them, which is strange.

After checking the game code, I think you patched the red part. (I don't know how, by the way, I'm not a modder)
repeaterPriorityFix7
But I suggest to patch the yellow part.

P. S. In the blockstate, the "facing" is actually the opposite direction:
repeaterPriorityFix5
repeaterPriorityFix6

[Suggestion] Dispensers should carve pumpkins (Would allow golem automation)

Essentially what it says on the tin. Would be nice to add an option, in the same vein as dispensersTillSoil and the vanilla dispenser flint-and-steel mechanics, to let dispensers carve pumpkins with shears. This would allow for fully automated snow golem factories in combination with autoCraftingDropper.

[Suggestion] Wither

With this rule enabled, if a wither would destroy an obsidian item entity, there is a small chance (1% or less) of dropping an ancient debris. This would make netherite farmable, and obtainable in Skyblock.

[Bug] AutoCraftingDropper and interaction with hoppers

Hi!

I'm experiencing an issue with autoCraftingDropper feature.

Expected behaviour:
As far as I know, hoppers, facing into autoCraftingDropper should input one item per slot.

What's actually happening:
Hoppers insert items normally (vanilla style).

Carpet version: 1.15.2-1.3.13
Carpet Extra version: 1.15.2-1.3.13+v200304

Fabric API version: 0.5.0+build.293-1.15

Items in hopper
2020-03-11_10 16 43

Items in autoCraftingDropper:
2020-03-11_10 17 06

Barrels and Bee Nests Dissappearing

It appears that while having carpet-extra mod for 1.15 installed, some blocks randomly disappear and cannot be interacted with. Removing the mod restores the blocks.

[enhancement] Potted wither rose doesn't work as chunkloader for flying machines.

I'd like to see a chunk loader moveable by pistons for tunnel bores and what not. the wither rose can't be moved and only loads one chunk so issues may occur with only part of flying machine in chunk.

Other than that im loving the mod so much to say in favor of it, don't want to burden you with a list of features you're already aware of.

[Suggestion] Wither netherite

With this rule enabled, if a wither would destroy an obsidian item entity, there is a small chance (1% or less) of dropping an ancient debris. This would make netherite farmable, and obtainable in Skyblock.

[Suggestion] Mobs that pick up generic items can despawn.

It's annoying to have a lot of zombies in your world that don't despawn because they're holding generic items such as stone blocks, string, gunpowder etc.
If this feature gets implemented, it would be cool if it's possible to customize which held items prevent mobs from despawning as well, that way people can set up their own blacklists.

[Suggestion] End rods break blocks

A rule that makes it so whenever an end rod is pushed into a block it breaks that block (Like in the mod quark), for balance sake I think that the end rod should break too, so that if you use dispensersPlaceBlocks it can theoretically be infinite. (The end rod dosent drop when used) It should be optinal whether or not the drop is the same as if silktouch was used.

[Suggestion] Snowballs defuse tnt

With this rule enabled, shooting a snowball at a primed tnt entity makes it unprime, for safety in case a machine explodes and for possible tnt farms. It should be optional whether or not the tnt becomes a block or just dissapears. (By exploding the tnt as block 36 you can make it drop for a farm)

switch in autoCraftingDropper from changing isValidInvStack to SidedInventory::canInsertInvStack

There is an issue with carpet-extra and hopperoptimizations. Carpet-extra uses isValidInvStack to make hoppers not insert items when there is already 1 item in the same slot of the autocrafting dropper. Therefore it will return false, when the stack is valid, but the slot already has an item. The correct solution would be to implement SidedInventory::canInsertInvStack instead.

SidedInventories usually do not have that property, that you suddenly cannot insert stuff. Even shulkerboxes are SidedInventories. Also the naming of the method implies that you are using it incorrectly, also how it is used now does e.g. beacons return true without checking if the slot is occupied already.

[REQUEST] Translocation

It would be great if we could restore translocation from MC1.10.

I remember seeing somewhere that this feature wouldn't be added to base carpet because translocation was a bug that had been fixed, but now carpet extra has restored dragon egg bedrock breaking.

Translocation seems like it's very similar to dragon egg bedrock breaking in that they were both very useful features for technical players while they were in the game and didn't really have downsides for other players, but were eventually patched nontheless.

[Suggestion] Dispensers interact with cauldron

Make dispensers to be able to interact with cauldron:

  • Dispensers with a water bucket can fill the empty cauldron in front of it, returning a empty bucket. If the cauldron has some water nothing happens (just don't drop it plz).

  • Dispensers with a water bottle can add one level of water to the cauldron in front of it, returning a empty bottle. If the cauldron is full nothing happens.

  • Dispensers with a empty bucket can empty the fully filled cauldron in front of it, returning a water bucket (or drop it if there's no room). If the cauldron isn't full nothing happens.

  • Dispensers with a empty bottle can remove one level of water from the cauldron in front of it, returning a water bottle (or drop it if there's no room). If the cauldron is empty nothing happens.

[Suggestion] [Crazy Idea] Portable update suppressor

When a Dragon Egg (or another rare special block) receives a NC-update, if a special condition is met, the dragon egg will throw a StackOverflowException in order to suppress the block update.

The special condition should be a little strict in order to prevent misoperation. For example:

  • The Dragon Egg is powered by redstone from a certain surface (maybe the top surface).

  • AND the Dragon Egg is sitting on a certain block.

  • AND the Dragon Egg is receiving a NC-update (not PP) from a Powered Rail (not other blocks).

Suggestion: Dispensers with pickaxes should mine blocks.

Suggesting dispensers with pickaxes (or other tools like shovels & axes) should be able to break the block in front of it. This would allow for quarry designs without the need for withers, TNT or AFK players.

The speed of the break and the drops given would depend on the tool and its enchantments, and damage would be dealt accordingly to the tool in question.

It would be cool if tools with mending could repair themselves in a dispenser as well.

autoCraftingDropper causes server crash when crafting v1.2.5

autoCraftingDropper causes server crash when crafting v1.2.5

Title is quite self explanatory, the crash happens when a(the only so far) iron block crater activates. The items are used up for the recipe and the result is picked up by the hopper under the crafting table when i restart the server again.

autoCraftingDroppers work fine in my singe player test world and on LAN worlds when i had a friend join. I have upgraded to the latest carpet version for 1.14.4 with the issue remaining.

My client sometimes displays "java.lang.StackOverflowError" from the server instead of "server closed" when the server crashes.

Server mod list:
[email protected],
[email protected],
[email protected]+build.174,
[email protected]

Client mod list:
carpet-extra-1.14.4-1.2.5
fabric-carpet-1.14.4-1.2.5+v191203
fabricmod_VoxelMap-1.9.13_for_1.14.4
litematica-fabric-1.14.4-0.0.0-dev.20190720.191654
malilib-fabric-1.14.4-0.10.0-dev.20
mamiyaotaru (folder)
mousewheelie-1.3.5+1.14.4

crash-2019-12-05_17.33.03-server.txt

carpet.conf.txt

/ping doesn't exist on server

Already ran command /carpet commandPing true
/ping
Prompt for unknown command

carpet-extra:1.0.5
fabric-carpet:1.0.6

Suggestion: Hoppers should push books into/pull from Lecterns

If hoppers (or a dispenser) could push enchanted books/book and quill into lecterns, and hoppers could suck the book back out, then lecterns could be used in sorting systems to separate this item type.

I don't know that the current lectern implementation is because it seems to be able to 'hold' a book and has some redstone interaction (comparator for reading page). So perhaps this is viable. It seems like a more likely candidate for this type of behaviour than the bookcase.

Additionally, you could change comparator logic from lecterns to allow enchanted book sorted. E.g.

  • A comparator in compare mode outputs signal strength based on enchanting level
  • A comparator in subtract mode is used to compare against another lectern to the side, if the other lectern has the same enchantment it output signal, if not, no signal. I.e. if lectern A being compared (subtract) has a fortune book in it, and the 'subtract from' lectern (B) as fortune, a redstone output is produced, if B does not have a fortune enchantment, then no redstone output is produced.

This would allow a complete enchanted book sorting system to be created.

Dragon Egg Bedrock breaking does not work

I tried it several times now in the 1.15.2 because it said that it brins the bug from 1.12.2 back for newer versions, but it did never work. After I saw that the rule is named y0DragonEggBedrockBreaking I thought that it is a fix for the 1.12.2, that you can break the y0 Bedrock with dragon eggs too. In the Description of the carpet rule on the carpet extra page (https://github.com/gnembon/carpet-extra) it says: "Reintroduce Dragon Egg Bedrock breaking bug from 1.12". So it would be nice if there is actually a rule which makes the bug from 1.12.2 work in never versions again.

Server crashing duplication glitch with CtrlQCraftingFix and AutoCraftingTable

Whenever using CtrlQCraftingFix's feature of fixing stack dropping in the crafting table while the carpet rule AutoCraftingTable is also enabled it creates an issue that causes for the item to be infinitely crafted without consuming items from the crafting table properly, causing for multiple thousand items to be dropped on the ground, crashing the game/server almost instantly.

The glitch can be recreated by:
Having carpet rule CtrlQCraftingFix set to true,
Having carpet rule AutoCraftingTable set to true
Holding down CTRL+Shift+Q while attempting to craft any item inside of a crafting table.

Video of glitch in action:
https://drive.google.com/file/d/1zNZBP6_40epvVPss54OW4ScloU7UoMe5/view

[Suggestion] A toggle for water/lava pushing entities

This would be very helpful for designing in tight spaces without getting pushed all over the place. Also some people may want to revert to the old lava. Commands I thought of are waterPushesEntities and lavaPushesEntities

[Feature request] [Survival] Hopper Jukeboxes

I suggest adding an option to Survival category to allow hoppers to insert discs into jukeboxes and, after finishing, to remove them too. Why? Cause why not - I want to play my music on loop :P I could find/make another mod for that (frick, I could probably even script this in scarpet), but Carpet is meant to be the one and only Vanilla enchancent mod you need, isn't it?
If it's too much for standard Carpet, consider adding it to Carpet Extra.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.