gnembon / fabric-carpet Goto Github PK

Hello, could this mod be posted on the curse platform? Aternos does not accept non-curse mods.

It would be very cool to be able to perform convolutions on a selected area with user-specified kernels. Properly implemented, this could be really useful to easily and seamlessly smooth out landscapes (using Gaussian kernels), generate Fourier series that generate the describe the terrain (using Dirichlet or Feijer Kernels), or locate block patterns in the map (using a kernel that the user designs with blocks in-game).

This is what exactly I did on a superflat world.
/player gnembon spawn
/player gnembon look down
/player gnembon jump continuous
Drop a glass block to him
/player gnembon place continuous
/player gnembon place once

Then the game crashed, saying something about entity ticking (I can't remember exactly).

There is an easier way to register commands without the use of mixins. See https://github.com/FabricMC/fabric/blob/master/fabric-testmods/java/net/fabricmc/fabric/commands/CommandMod.java

Hello, adding this here as requested on CurseForge. I'd love to see the fix for MC-2025 added again on Carpet. Extremely persistent bug that has returned on the latest versions.

Thank you in advance!

When running the script I /script run if (query(player(), 'holds') == epic, print('epic')); the cryptic error "your thoughts are too deep" is shown what is that error and what does it mean?

Some Blockstate changes are not sent to client.
Related blocks are: cactus, sugar cane, saplings, hopper, dispenser and dropper.

For dispenser and dropper, the triggered state does not change when it is powered/depowered.
For hopper, the enable state does not change when it is powered/depowered.
For cactus and sugar cane, the age state does not change when it is growing.
For sapling, the stage state does not change when it is growing.

This is because the setBlockState() method (net.minecraft.world.World.setBlockState(), in 1.14.4 forge) is called with a flag of 4, so the changes are not sent to clients, since the 0x2 bit is 0.

This issue doesn't affect the gameplay, but it makes creating a resourcepack to display these blockstates impossible. As a technical player, I like using some kinds of "blockstate displaying resourcepack", but because of this issue, the visualization of these Blockstates is messed.

Mojang don't consider it as a bug, by the way. It will be good if this issue is fixed in carpet mod. With a separated setting, just like other bug fix features.
Bug report link: https://bugs.mojang.com/browse/MC-70127

When I try to start my server with only carpet and fabric API in my mods folder I get a crash on start.
log.txt

Hello!

I couldn't find a way to get the name of an item which is held in the main hand. We want to use the hammer script, but with a diamond pickaxe which has the name "Hammer".

My question/issue: Can you check the name of an item and if so, how?

Pressing Q (drop keybind) on a craftable recipe will put it into the crafting slots and drop the result.

While trying to setup a fake player to place saplings in a single spot, I used the command "/player <> use continuous," but no action is performed. I see in the source code the command needs to be updated due to 1.14 changes.
Will this will be updated in the future?

If I try to start Minecraft 1.14.4 with carpet 1.0.3, the game always crashes. I already removed all my other mods and tried with/without the fabric-api.
Here's the stacktrace:

Exception in thread "Client thread" java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:172)
	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:129)
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
Caused by: java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:170)
	... 2 more
Caused by: java.lang.IncompatibleClassChangeError: Method 'void net.minecraft.class_2357.handler$addBlockRotator$zdc000(org.spongepowered.asm.mixin.injection.callback.CallbackInfo)' must be InterfaceMethodref constant
	at net.minecraft.class_2357.method_18346(class_2357.java)
	at net.minecraft.class_2966.method_12851(class_2966.java:53)
	at net.minecraft.class_310.<init>(class_310.java:383)
	at net.minecraft.client.main.Main.main(Main.java:155)
	... 7 more

I am btw running the mod client-side, maybe its a server-only mod? If so, please specify that in the README.

I have the carpet mod in the Minecraft mod folder for my 3rd party run server, however none of the available commands show up for the carpet mod, they are all still the default Minecraft commands

Upon returning to survival via /s command, the player can see in dark. Doesn't fix via restart/reload.
Also, I've noticed if you enter the camera mod via /c and return to survival via /gamemode survival, you can see in dark and breath underwater. Water breathing is fixed with using /s, but night-vision stays.

All modifications I have are FabricAPI, Fabric-Carpet, Optifabric, Optifine.
Fabric-Carpet is v19_07_14 for 14.4-sunny.

New to this mod, so it could be I'm doing something wrong.

I'm trying to run a 1.14.3 released version and getting the following crash upon start

[14:18:48] [main/WARN]: Mixin config carpet.mixins.json does not specify "minVersion" property
Exception in thread "main" java.lang.RuntimeException: Failed to setup Fabric server environment!
        at net.fabricmc.loader.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:51)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: An exception occurred when launching the server!
        at net.fabricmc.loader.launch.server.FabricServerLauncher.setup(FabricServerLauncher.java:107)
        at net.fabricmc.loader.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:49)
Caused by: java.lang.RuntimeException: An exception occurred when launching the server!
        at net.fabricmc.loader.launch.server.FabricServerLauncher.launch(FabricServerLauncher.java:63)
        at net.fabricmc.loader.launch.server.FabricServerLauncher.setup(FabricServerLauncher.java:105)
        ... 1 more
Caused by: java.lang.reflect.InvocationTargetException
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:567)
        at net.fabricmc.loader.launch.server.FabricServerLauncher.launch(FabricServerLauncher.java:61)
        ... 2 more
Caused by: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
        at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:172)
        at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:129)
        at net.fabricmc.loader.launch.knot.KnotServer.main(KnotServer.java:26)
        ... 7 more
Caused by: java.lang.reflect.InvocationTargetException
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:567)
        at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:170)
        ... 9 more
Caused by: java.lang.IncompatibleClassChangeError: Method net.minecraft.class_2357.handler$addBlockRotator$zcm000(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V must be InterfaceMethodref constant
        at net.minecraft.class_2357.method_18346(class_2357.java)
        at net.minecraft.class_2966.method_12851(class_2966.java:53)
        at net.minecraft.server.MinecraftServer.main(MinecraftServer.java:897)
        ... 14 more

Building from the sources with the latest source code (for 14.4pre4) gives similar error. Doesn't matter whether external server is used or ./gradlew runServer. Am I missing something?

If you disable fillUpdates and load a structure that contains an observer the observer will still activate. The same does not happen when using fill, setblock or clone.

How to reproduce

• Disable fillUpdates
• Use a structure block to save a structure containing a observer
• Load said structure. The observer will activate

Observers also activate when a structure is place next to them.

The location of players/entities is x, x, x instead of x, y, z.

Noticed that by running /camera start and seeing in chat "Started path at -211 -211 -211".

I have carpet running on a 1.14.2 server, and I like having it show the tps in the tab screen (/log tps), but everytime the server restarts it unsubscribes us from it and we have to type /log tps again. Also everytime I restart, my scoreboard I have set up to also show in the tab screen reverts to this custom datapack one, tho then again that could just be a "feature" of that datapack.

When a fake player tries to go through End exit portal, it (player, ya) disapears. It has position (right above the portal), but is not avilable for any interaction and is not visible.
P.s. End gate in Overworld works fine
1.14.4 server, carpet 1.0.8

Phantom spawning rates cannot be changed from /spawn rates monster.

Preface:
I'm afraid I couldn't find any guidelines on how to post an issue here so I hope I have formatted this in a useful way! If this is the wrong place to write this, please kindly direct me to the proper location.

I'd be more than happy if someone responded to this with a "It's simple dummy, don't you know how to do anything!? Just do X!"

Issue:
I can't for the life of me get the carpet mod working on a server. I can start up the world and join it with clients just fine with nothing in the mods folder but, as soon as I add the carpet jar, it can no longer start up the server.

I am just not familiar enough with fabric and carpet to know why these mixins would be having an issue.

Fabric and Carpet versions/files:
I am trying to use version 1.1.3 (fabric-carpet-19w42a-1.1.3+v191016.jar) for MC 1.14.4 with the vanilla fabric-server version from "fabric-installer-0.5.1.36.jar" (loader 0.6.3+build.167).

Operating system/java version:
I'm trying to run it on Ubuntu Server 18.04.3 using Java SE Runtime 1.8.0_181-b13.

Log file:
https://pastebin.com/n6EFz8nL

Any help you could offer (even if it is pointing me somewhere else) would be greatly appreciated.

Thanks!

I am unable to find a way to remove players from the game that were spawned by the /playerSpawn command. I have tried to kick them via the /kick command but even though it succeeds, the player remains in the game.

crash-2019-05-28_17.22.47-server.txt

Hi, I noticed a problem with carpet.
Whenever I Ctrl-Q an item in a crafting table, it will duplicate the item continuously, causing an insane amount of lag and inevitably, crashing the server. This seems to be the cause of all crafted items. See the image below.

We are running a server on 19w44a with carpet mod being on version 1.2.1+v191030
I think it is caused by carpet because it does not have this effect in singleplayer with pure vanilla.

maybe I'm really stupid, but iI have no ides howe to install it. So my wish for the future would be, that ther is an instruction how to install scarpet (and one that updates when the method changes)

Could you compatible java11 in future?
fabric carpet does not work in java11.

crash log:

Exception in thread "Client thread" java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:180)
	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:131)
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
Caused by: java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:178)
	... 2 more

Caused by: java.lang.IncompatibleClassChangeError: Method net.minecraft.class_2357.handler$addBlockRotator$zdd000(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V must be InterfaceMethodref constant
	at net.minecraft.class_2357.method_18346(class_2357.java)
	at net.minecraft.class_2966.method_12851(class_2966.java:53)
	at net.minecraft.class_310.<init>(class_310.java:383)
	at net.minecraft.client.main.Main.main(Main.java:155)
	... 7 `more`

Running the latest Fabric-Carpet versions and have shulkers spawning on rails. I used Quickcarpet to easily see the bounding box and set up a farm and everything ran smoothly. I then switched back to Fabric-Carpet and got the issue. I'm fairly certain they are actually spawning there and not simply teleporting to them. They shouldn't do either, though. Another interesting note is the spawning of them seems much more aggressive with Fabric-Carpet than with Quickcarpet.

the lagfreespawing feature in /carpet thing makes mobs spawn in spawnoproofed areas such as slabs string glass and carpet

Attach a video maybe? Please... Also what forge version EXACTLY. Please. I really want to know. :(

/script run print(get(player() ~ 'holds', 0))

I use the command above, I don't know if I use it incorrectly, but even if I change the number, the message is the same on every third number. I don't know what I'm doing wrong, I checked the documentation, and I still don't know how to get the name of an item.

I'm trying to send Skulkers through the end exit to the Overworld. In testing with portal caching enabled Skulkers consistently go between 0, 0 and to the world spawn. Seems it switches between them each time. When it's disabled they always go to 0, 0 as expected.

I cannot seem to tick forwards in sp while I'm in spectator with another NPC player(/player) afking.
After a few seconds passing with /tick active(both rate and warp) the game crashes spewing these:
Log:
https://pastebin.com/raw/By0aL9GB
Crash-Report:
https://pastebin.com/raw/Dxh2kt2N

In Minecraft 1.7.10 and below, the tile tick priorities of Repeater are following:

• [-3] if pointing into a Repeater/Comparator with a different direction;
• [-2] if lit;
• [-1] for the rests.

And the tile tick priorities of Comparator are following:

• [-1] if pointing into a Repeater/Comparator with a different direction;
• [0] for the rests.

The priority of a Repeater/Comparator is increased when it is pointing into another Repeater/Comparator with a different direction. I personally call it "Priority Upgrade".

But after updating to Minecraft 1.8, the requirement of the "Priority Upgrade" is changed to:

• if pointing into a Repeater/Comparator, which does not have a OPPOSITE direction.

This cause a problem: when a chain of 1-tick repeater is connected to a 4gt clock (2gt on, 2gt off), the last repeater stays powered.

This issue still exists in 1.15 snapshots, and is reported to Mojang multiple times. Maybe Mojang just don't consider it is a bug.
(Methodzz even talked about this in "Dissecting Minecraft", as a feature)
Bug report link: https://bugs.mojang.com/browse/MC-54711

Some times this is quite annoying. So it will be good if this issue is fixed in carpet mod. With a separated setting, just like other bug fix features.

This issue seems to relate to following code in RedstoneDiodeBlock class (base class of Repeater/Comparator):
public boolean isFacingTowardsRepeater(IBlockReader worldIn, BlockPos pos, BlockState state) {
Direction direction = ((Direction)state.get(HORIZONTAL_FACING)).getOpposite();
BlockState blockstate = worldIn.getBlockState(pos.offset(direction));
return (isDiode(blockstate) && blockstate.get(HORIZONTAL_FACING) != direction);
}
(code from 1.14.4 forge)
If this method returns true, the Repeater/Comparator will perform a "Priority Upgrade"

here is the crash message:
net.minecraft.class_148: Exception ticking world
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:828) ~[intermediary-server.jar:?]
at net.minecraft.class_3176.method_3813(class_3176.java:343) ~[intermediary-server.jar:?]
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:763) ~[intermediary-server.jar:?]
at net.minecraft.server.MinecraftServer.handler$modifiedRunLoop$zzj000(MinecraftServer.java:2242) ~[intermediary-server.jar:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:610) [intermediary-server.jar:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_201]
Caused by: java.lang.NullPointerException
at carpet.utils.SpawnReporter.registerSpawn(SpawnReporter.java:82) ~[fabric-carpet-v19_06_24_for_14_3_sunny.jar:?]
at net.minecraft.class_1948.redirect$spawnEntity$zch000(class_1948.java:589) ~[intermediary-server.jar:?]
at net.minecraft.class_1948.method_8663(class_1948.java:157) ~[intermediary-server.jar:?]
at net.minecraft.class_3215.redirect$spawnMultipleTimes$zcg000(class_3215.java:1108) ~[intermediary-server.jar:?]
at net.minecraft.class_3215.method_20801(class_3215.java:362) ~[intermediary-server.jar:?]
at it.unimi.dsi.fastutil.longs.Long2ObjectLinkedOpenHashMap$1.forEach(Long2ObjectLinkedOpenHashMap.java:1661) ~[server.jar:?]
at com.google.common.collect.Iterables$UnmodifiableIterable.forEach(Iterables.java:105) ~[fabric-server-launch.jar:?]
at net.minecraft.class_3215.method_14161(class_3215.java:327) ~[intermediary-server.jar:?]
at net.minecraft.class_3215.a(class_3215.java:296) ~[intermediary-server.jar:?]
at net.minecraft.class_3218.method_18765(class_3218.java:310) ~[intermediary-server.jar:?]
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:824) ~[intermediary-server.jar:?]
... 5 more
and here is the crash report.
crash-2019-06-27_23.30.45-server.txt
I am using the lastest version of carpet for 1.14.3 and I am trying to test one of my farms

When having both fabric-carpet and tweakaroo installed and launching a singleplayer world,
the internal server crashes due to both tweakaroo and fabric-carpet attempting to overwrite the clone limit with the same priority. I don't know how this could be fixed, attached is the crash log.

https://paste.ee/p/D9T3L

Branch: master

Performed:
git clone https://github.com/gnembon/fabric-carpet.git
cd fabric-carpet/
./gradlew genSources eclipse
./gradlew build

Build error:

/home/ne/gits/fabric-carpet/src/main/java/carpet/mixins/WorldChunk_movableTEMixin.java:5: error: package com.sun.istack.internal does not exist
import com.sun.istack.internal.Nullable;
^
/home/ne/gits/fabric-carpet/src/main/java/carpet/mixins/WorldChunk_movableTEMixin.java:42: error: cannot find symbol
@nullable
^
symbol: class Nullable
location: class WorldChunk_movableTEMixin
/home/ne/gits/fabric-carpet/src/main/java/carpet/mixins/WorldChunk_movableTEMixin.java:69: error: cannot find symbol
@nullable
^
symbol: class Nullable
location: class WorldChunk_movableTEMixin

I open minecraft it says this. Idk... help please

Enviroment:
Tested with following JDKs: jdk-12.0.1, jdk1.8.0_151, jdk1.8.0_211

Gradle version:
Gradle 5.4
Build time: 2019-04-16 02:44:16 UTC
Revision: a4f3f91a30d4e36d82cc7592c4a0726df52aba0d
Kotlin: 1.3.21
Groovy: 2.5.4
Ant: Apache Ant(TM) version 1.9.13 compiled on July 10 2018
JVM: 1.8.0_211 (Oracle Corporation 25.211-b12)
OS: Windows 10 10.0 amd64

Files: Carpet Fabric Mod alpha v19_06_24+ source code, and with gradle genSources idea (I use IntelliJ Idea) done.

Issue: When compiling with gradle build, I get 13 warnings: https://pastebin.com/c0HANDHp

If I use the fabric-carpet-1.14.4-1.0.0+v190714.jar from build/libs and put it to the mods folder of a fabric server. Log: https://pastebin.com/1vehgS4H

It seems like the husks spawning in temples feature does not result in a noticeable change of vanilla behavior.
Normal mobs spawn everywhere in the pyramids bounding box - husks only spawn with sky access in it.

Steps to reproduce:

• create new world in single-player (irrelevant which world type)
• enable husk spawning in carpet and enable it by default
• find a pyramid and display its bounding box (for example with miniHUD)
• make multiple spawn floors inside the bounding box and clear the surrounding world to get a perimeter
• watch as hostile mobs of all types spawn in the bounding box but husks only with sky access

When I place a renamed shulker box and then break it with nothing inside, the shulker box looses its name. Pretty sure it's beacasue of stackableShulkerBoxes, cause I don't think anything else in carpet changes shulker boxes and it doesn't occur on server without Carpet.

Result from running script sound('block.anvil.use', pos(player()))
crash-2019-07-28_22.56.24-server.txt

Commands /draw, /tick, /spawn, /track, /info, /distance, /script, /c and /s are available for non-op players.
However, I think /s, /c, /track, /info and /distance should be available for everyone. Possibly /script too.

Hi,
I am using SkyBlock module with fabric-carpet and I am not able to store default value.
I get this error "Unknown rule: wanderingTraderSkyblockTrades".

I am using only the 2 module "fabric-carpet" and "skyblock"

Generated link is "/carpet setDefault wanderingTraderSkyblockTrades true" and should be "/skyblock setDefault wanderingTraderSkyblockTrades true"

Same with other links.

Forwarded from skyrising/skyblock#3

Error message: java.lang.IllegalStateException: Removing entity while ticking!
crash-2019-07-07_13.22.30-server.txt
It is a 1.14.3 server with the latest version of fabric-carpet.

This is probably a really dumb issue with a simple solution, but I don't have carpet.jar in the file! I've looked everywhere an ran everything and there is NO carpet.jar. Please help, I really want to use this mod!

If there is any more information needed please say, I will gladly provide it.

When I start the fabric server it crashes with this stack trace: https://pastebin.com/raw/W53e2usD
I have no other fabric mods installed, but the server can start with other mods when fabric-carpet is not present. I am running the newest fabric version on Minecraft 1.14.4 with fabric-carpet 1.0.8.