Partially matching call arguments about mock-contract HOT 8 OPEN

The MockContract allows for all of that without having to write a separate test contract each time.

Maybe like this?
The MockContract facilitates these features without requiring any separate test contracts.

Should we also make the interface we expect to be implemented explicit?

done

from mock-contract.

The MockContract facilitates these features without requiring any separate test contracts.

Much better!

from mock-contract.

what is the value of making ANY also a constant?

ANY has to be defined somewhere, otherwise the code wouldn't compile. My suggestion would be to have it some magic value on the smart contract.

from mock-contract.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.5 ETH (106.07 USD @ $212.14/ETH) attached to it as part of the Gnosis fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $142,366.64 more funded OSS Work available on the Gitcoin Issue Explorer

from mock-contract.

Looks really good! A few small comments.

The MockContract allows for all of that without having to write a separate test contract each time.

This sentence could be slightly smoother, but I don't have a concrete suggestion either. Maybe @bh2smith ?

After the ANY example, we might want to add that ANY can be a e.g. a constant defined on the smart contract.

Should we also make the interface we expect to be implemented explicit?

function givenPartialCalldataReturn(bytes calldata call, bytes calldata response) external;
...

from mock-contract.

After the ANY example, we might want to add that ANY can be a e.g. a constant defined on the smart contract.

what is the value of making ANY also a constant? Probably, I do not understand.

from mock-contract.

Issue Status: 1. Open 2. Cancelled

Workers have applied to start work.

These users each claimed they can complete the work by 2 years, 4 months ago.
Please review their action plans below:

1) mikehathaway has applied to start work (Funders only: approve worker | reject worker).

I will use Truffle Suite tools to run a local Eth node and rapidly prototype a smart contract that can be used for mocking Gnosis contract interactions. Following completion of a contract that meets basic specifications, I will seek to iteratively improve it.

Learn more on the Gitcoin Issue Details page.

from mock-contract.

Issue Status: 1. Open 2. Cancelled

The funding of 0.5 ETH (67.09 USD @ $134.18/ETH) attached to this issue has been cancelled by the bounty submitter

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $79,939.62 more funded OSS Work available on the Gitcoin Issue Explorer

from mock-contract.