Calldata with predicates about mock-contract HOT 8 OPEN

One cool hack that was presented at EthLondon last weekend is Lurch, which allows evaluating arbitrary bytecode given some calldata.

We could implement the predicate as bytecode and pass it in to the MockContract. Then when the mock contract matches the method-name it could evaluate the bytecode given the calldata in lurch and if it returns true execute the given expectation.

I'm not sure how practical it will be to compile predicates into bytecode and if it could be done nicely in JS.

from mock-contract.

My two cents in case anyone cares: I feel like solidity needs some extra features before something like this can be implemented, unless you do something like deploying ad-hoc contracts, like @fleupold suggested.

More specifically, I think for doing this you should need to store information about how to decode a given calldata, but AFAIK you can't store a tuple of types, which is the type of the second parameter of abi.decode:

abi.decode(someBytes, (uint, string))

I mean, someone calling a givenPredicateCalldata* method should also provide info about how to decode this. If this is possible, I think #14 becomes much easier too.

from mock-contract.

@bh2smith Yeah, they are exercises, which will be posted in gitcoin. It is not specifically for trufflecon

from mock-contract.

This one is a little more tricky than the previous one. I was thinking that we could actually allow people to write the predicate as a boolean expression in solidity (with a somehow defined naming scheme for variables).

E.g. GREATER_THAN(10) could be implemented as

contract.method.givenConditionReturn("arg0 > 10", true)

which under the hood (in js) could be implemented by deploying a new contract instance (using something like this) which inherits MockContract, and implements the method something like:

function method(arg0, arg1, ...) returns (bool) {
  if ($condition) {
    return $returnValue
  } else {
    super.method(arg0, arg1, ...)
  }
}

Of course there is still some more fine technical detail which has to be ironed out, which is why this task is definitely more involved than #14

But I'm also happy leaving it open like this to see if someone comes up with a better idea.

from mock-contract.

Don't forget to update this!

The MockContract allows for all of that without having to write a separate test contract each time.

with

The MockContract facilitates these features without requiring any separate test contracts.

from mock-contract.

Are these exercises to be given out for prizes at the trufflecon?

from mock-contract.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.75 ETH (159.1 USD @ $212.14/ETH) attached to it as part of the Gnosis fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $142,366.64 more funded OSS Work available on the Gitcoin Issue Explorer

from mock-contract.

Issue Status: 1. Open 2. Cancelled

The funding of 0.75 ETH (100.64 USD @ $134.18/ETH) attached to this issue has been cancelled by the bounty submitter

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $80,006.89 more funded OSS Work available on the Gitcoin Issue Explorer

from mock-contract.