[Bug] Empty xaxis/yaxis dictionary, bar.SetXAxis() is broken about go-echarts HOT 7 CLOSED

Hi @CaledoniaProject , if you need the pure JSON options directly.
You need call the bar.Validate() before bar.JSON() since the XYAxis config is post processed in Validate().

a := barBasic()
a.Validate()
b, _ := json.Marshal(a.JSON())

from go-echarts.

Interesting,

1. why won't go-echarts call Validate() inside JSON()
2. the sample code does not call Validate() and it still works, why is that?

@Koooooo-7

from go-echarts.

1. why won't go-echarts call Validate() inside JSON()

go-echarts does call the Validate() before render it to HTML, otherwise, the options gonna be broken as you mentioned above either.

2. the sample code does not call Validate() and it still works, why is that?

TBH, at the very beginning, the Validate() seems a validation function, somehow it contains some post process stuff also.
And the JSON() method is made for template render, it does not meant to be an open api for now.

from go-echarts.

@Koooooo-7 Looks like the API needs some refactoring. So if it's not meant to be a public API, should I use json.Marshal() after Validate() ?

from go-echarts.

@Koooooo-7 Looks like the API needs some refactoring. So if it's not meant to be a public API, should I use json.Marshal() after Validate() ?

Personally I think works as expect for now, because go-echarts aims to generate echarts styling charts, not being designed to generate echarts' options (and actions, events...etc). so, there is no the sort of export api for getting individual configs for echarts.
The JSON() object more like the mid-product to go-echarts.
If you do wanna the JS options, copying from the generated bar HTML is more reasonable to me.
This way below just plays a trick as a workaround.

a := barBasic()
a.Validate()
b, _ := json.Marshal(a.JSON())

from go-echarts.

@Koooooo-7 My situation is a golang server + VUE frontend, I use go-echarts to avoid defining the options structure in golang. I think it's a common usage scenario. It works for now :-)

from go-echarts.

@Koooooo-7 My situation is a golang server + VUE frontend, I use go-echarts to avoid defining the options structure in golang. I think it's a common usage scenario. It works for now :-)

Glad to hear that, it should work in basic charts for now.
I think go-echarts could consider provide some export api in future for echarts options if it needs.

from go-echarts.