go-icap / icap Goto Github PK

Hello
It could be nice to have a small example (client and server) not doing a lot, 
but showing concretely how to use properly the library, eg concatenate chunked 
data and store it into a file, or something like that.

extra question : what is according to you the maturity of the library?

regards

Original issue reported on code.google.com by [email protected] on 4 Oct 2011 at 6:57

The ICAP service example will process both GET and other methods HTTP requests but will not implement the required code.
The main issue is that the OPTIONS present a picture to the ICAP client about that it can process the whole request with body if exists but the example code doesn't handle requests with body in a way that meets the RFC.
So in order to avoid a situation which the ICAP service cannot handle the request there is a need to add a preview restriction to the headers using(related to the example):
h.Set("Preview", "0")
h.Set("Transfer-Preview", "*")
Would be enough to make the service usable for requests with body allowing a situation which the body transfer and handling is being optional and by that allowing a 204 response before any data is being sent from the ICAP client about the body.
The relevant RFC section is:
http://www.rfc-base.org/txt/rfc-3507.txt
section 4.10.2 OPTIONS Response

If you want me to fix it I will fork and then I will send a pull request.

What steps will reproduce the problem?

goinstall go-icap.googlecode.com/hg

What is the expected output? What do you see instead?

I expected, that the module gets installed correctly.

Instead I get the following error:

go-icap.googlecode.com/hg: download failed: unsupported import path; should be 
"code.google.com/p/go-icap"

What version of the product are you using? On what operating system?
go-icap tip with 6g weekly.2012-01-15 11253

Please provide any additional information below.

Attached is a small patch, which fixes the path in the Makefile and in the 
example redirector.

Original issue reported on code.google.com by [email protected] on 27 Jan 2012 at 1:21

Attachments:

• go-icap-importpath.diff