Comments (5)
looks like the panic is an old "debug catch all" of mine.
continue
-ing seems fine. (perhaps we should at some point bubble up that error w/o breaking the accept-loop. but that probably can be addressed in another PR)
from zmq4.
do you have the panic traceback?
(before investing time in implementing "version negotiation", I'd prefer to be sure this is actually the issue at hand :P)
from zmq4.
Hi sbinet,
I only have this stacktrace. And I can provide a minimal example project that causes the crash.
Example code: https://filebin.net/okurjnjpohukq2oo
Compiled for Linux: https://filebin.net/hldy9oyn0ips4aan (connects to tcp://localhost:5556)
from zmq4.
I have updated zmq4
to display the version announced by the greeting.
could you update the issue with the version you received?
that would help in devising the amount of work to fix this.
thanks.
from zmq4.
Hi @sbinet,
regarding this issue there is another point.
For example with a nmap localhost -p <zmq-port>
we'll get a panic too. Couldn't we replace the panic(err)
with a continue
?
This way we'll ignore if a connection couldn't be opened, but we wouldn't break active connections due to the panic:
Lines 194 to 198 in 018f24d
I'll open a PR, if wanted
from zmq4.
Related Issues (20)
- New connReaper go routine started on every Connect/Listen HOT 1
- Subscribe() after Listen() doesn't works
- No messages getting through XPUB/XSUB proxy HOT 7
- pub sub err , when close the server the client get error and close HOT 1
- Go channel interface
- meta: consider setting up an OpenCollective account HOT 1
- router node restart recv block
- SUB socket SetOption must come after Dial, goczmq/pebbe don't have such limitation HOT 1
- Pull socket can not be properly closed, if no clients ever connected HOT 3
- REP socket races on client connection
- no reconnect possible when using `zmq4.NewPub` with `socket.Dial` HOT 4
- Why is go-zeromq/zmq4 not needing libzmq on windows? HOT 1
- socket accept a new connection, will send and read the greet message,if client always not response with greet message,other client can't connect to server
- Dead lock, how to fix? HOT 2
- github.com/pebbe/zmq2 (2.2.0) sub socket cannot connect to github.com/go-zeromq/zmq4 pub socket HOT 2
- Can't get a proxy to work (XSUB/XPUB)
- subSocket.Topics() is not accessible
- Dial timeout? HOT 7
- Socket can only Listen to one endpoint HOT 3
- The frame is lost in request response HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zmq4.