Giter VIP home page Giter VIP logo

Comments (5)

sbinet avatar sbinet commented on August 16, 2024 1

looks like the panic is an old "debug catch all" of mine.
continue-ing seems fine. (perhaps we should at some point bubble up that error w/o breaking the accept-loop. but that probably can be addressed in another PR)

from zmq4.

sbinet avatar sbinet commented on August 16, 2024

do you have the panic traceback?
(before investing time in implementing "version negotiation", I'd prefer to be sure this is actually the issue at hand :P)

from zmq4.

ThatsNotMyCode avatar ThatsNotMyCode commented on August 16, 2024

image

Hi sbinet,

I only have this stacktrace. And I can provide a minimal example project that causes the crash.
Example code: https://filebin.net/okurjnjpohukq2oo
Compiled for Linux: https://filebin.net/hldy9oyn0ips4aan (connects to tcp://localhost:5556)

from zmq4.

sbinet avatar sbinet commented on August 16, 2024

I have updated zmq4 to display the version announced by the greeting.
could you update the issue with the version you received?
that would help in devising the amount of work to fix this.

thanks.

from zmq4.

IoTMOD avatar IoTMOD commented on August 16, 2024

Hi @sbinet,
regarding this issue there is another point.
For example with a nmap localhost -p <zmq-port> we'll get a panic too. Couldn't we replace the panic(err) with a continue?
This way we'll ignore if a connection couldn't be opened, but we wouldn't break active connections due to the panic:

zmq4/socket.go

Lines 194 to 198 in 018f24d

zconn, err := Open(conn, sck.sec, sck.typ, sck.id, true, sck.scheduleRmConn)
if err != nil {
panic(err)
// return xerrors.Errorf("zmq4: could not open a ZMTP connection: %w", err)
}

I'll open a PR, if wanted

from zmq4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.