Giter VIP home page Giter VIP logo

Comments (10)

GoEddie avatar GoEddie commented on July 26, 2024

Hi Hendra,

It is because ApplyTrigger creates a new object and we use an object cache to lookup the name - when we generate the list of names it hasn't been re-created again.

I will try to include the fix to this in an upcoming release.

Ed

from sqlcover.

gedeh avatar gedeh commented on July 26, 2024

Hi Ed,

Thanks for your explanation, just looked into tSQLt's ApplyTrigger code and yes you're right it copies the original trigger to apply to target table. I was assuming it use the original trigger, so I thought it was a bug in SQLCover :)

Thanks for considering this as one of feature request as part of the upcoming release. Any ETA? :)

Thanks again,
Hendra

from sqlcover.

GoEddie avatar GoEddie commented on July 26, 2024

I'll have a look and see how easy it will be to add in - which version of sql do you use? It might be easier on newer versions of sql (2012+)

ed

from sqlcover.

gedeh avatar gedeh commented on July 26, 2024

Hi,

The database project under test has its compatibility level set to SQL Server 2008. But it always deployed to at least SQL Server 2012+. One of the plan is once we have a good coverage, we can raise the compatibility level to latest version.

But if necessary, I think I can up the compatibility level to SQL Server 2012 for testing purpose.

Hendra

from sqlcover.

RuudVerhoef avatar RuudVerhoef commented on July 26, 2024

I seem to be facing the same problem using SQL Server 2016 in combination with tSQLt.

Is it correct that this issue still exists or is there a fix for this (student here)?

from sqlcover.

martinisaksen avatar martinisaksen commented on July 26, 2024

This won't be possible until tSQLt adds some code on their side. I have some extra changes I added to tSQLt and SQL Cover to make this work. I have a fork of this project that has these changes and it has been updated to .Net Core 3.1.

I'm just waiting for tSQLt to add their part so I can create a PR into this repo

from sqlcover.

sgtwilko avatar sgtwilko commented on July 26, 2024

@martinisaksen is this still waiting on tSQLt?

from sqlcover.

martinisaksen avatar martinisaksen commented on July 26, 2024

I don't remember my PR ever getting merged so it is probably still waiting on that.

from sqlcover.

sgtwilko avatar sgtwilko commented on July 26, 2024

Hiya @martinisaksen
Seeing as this project seems to be dead, have you moved to another, or still working on your own copy?

We're looking at using this fork https://github.com/sayantandey/SQLServerCoverage

and having triggers covered would be handy!

from sqlcover.

martinisaksen avatar martinisaksen commented on July 26, 2024

from sqlcover.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.