Comments (10)
Hi Hendra,
It is because ApplyTrigger creates a new object and we use an object cache to lookup the name - when we generate the list of names it hasn't been re-created again.
I will try to include the fix to this in an upcoming release.
Ed
from sqlcover.
Hi Ed,
Thanks for your explanation, just looked into tSQLt's ApplyTrigger code and yes you're right it copies the original trigger to apply to target table. I was assuming it use the original trigger, so I thought it was a bug in SQLCover :)
Thanks for considering this as one of feature request as part of the upcoming release. Any ETA? :)
Thanks again,
Hendra
from sqlcover.
I'll have a look and see how easy it will be to add in - which version of sql do you use? It might be easier on newer versions of sql (2012+)
ed
from sqlcover.
Hi,
The database project under test has its compatibility level set to SQL Server 2008. But it always deployed to at least SQL Server 2012+. One of the plan is once we have a good coverage, we can raise the compatibility level to latest version.
But if necessary, I think I can up the compatibility level to SQL Server 2012 for testing purpose.
Hendra
from sqlcover.
I seem to be facing the same problem using SQL Server 2016 in combination with tSQLt.
Is it correct that this issue still exists or is there a fix for this (student here)?
from sqlcover.
This won't be possible until tSQLt adds some code on their side. I have some extra changes I added to tSQLt and SQL Cover to make this work. I have a fork of this project that has these changes and it has been updated to .Net Core 3.1.
I'm just waiting for tSQLt to add their part so I can create a PR into this repo
from sqlcover.
@martinisaksen is this still waiting on tSQLt?
from sqlcover.
I don't remember my PR ever getting merged so it is probably still waiting on that.
from sqlcover.
Hiya @martinisaksen
Seeing as this project seems to be dead, have you moved to another, or still working on your own copy?
We're looking at using this fork https://github.com/sayantandey/SQLServerCoverage
and having triggers covered would be handy!
from sqlcover.
from sqlcover.
Related Issues (20)
- add topic hacktoberfest
- Postgres, mysql support HOT 3
- dotnet core tool published
- Support SQL Server inline table valued functions? HOT 1
- Cannot use or export using Cobertura on CoverageResult HOT 1
- Generating partial test coverage report for the Azure DB. HOT 4
- Default Tracing error with SQLLocalDB datasource based on Windows named pipe line HOT 2
- Publish Coverage Results in Azure DevOps HOT 1
- Exception running code coverage: Unable to cast object of type 'System.DBNull' to type 'System.String' HOT 1
- How to exclude database objects from coverage reports? HOT 4
- SQLCover filters out the SP that has index created on table variable
- News about release 0.6 or what's next? HOT 1
- Allign to the OpenCover format https://github.com/csMACnz/coveralls.net is using
- download link broken
- Cobertura updates/adherence HOT 1
- Missing max_rollover_files option in definition of event session target file leads to lost of coverage info HOT 1
- Question: Is it possible to run SQLCover on Linux? HOT 1
- Unable to generate code coverage on database hosted on linux docker container HOT 1
- Is this project no longer maintained? HOT 2
- GitHub action jobs currently failing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlcover.