gogs / git-module Goto Github PK

According to http://stackoverflow.com/a/8347325/2693792 (and some of my repositories) the mode field could contain 100664, too (regular non-executable file, group-writeable).

That leads to to the error [...routers/repo/view.go:44 renderDirectory()] [E] ListEntries: unknown type: 100664 and hence to render the status/500-page

@unknwon as I mentioned on Gitter, IMHO git-shell is unlucky name. While I understand your intention that you wanted use pure git shell command but there are few caveats:

1. This project is not a shell, it is a library (module, API, wrapper), see definition of Shell
2. There is already git-shell part of official Git project and it is something else (a real but restricted login shell in fact) see https://git-scm.com/docs/git-shell

Therefore consider renaming the project to something like go-git-module, go-git-wrapper or some other name which reflects what is the purpose of this project. This will help community to properly lookup your project and help with extending it.

Implement ability to limit the goroutine number on the method GetCommitsInfo. Now, the concurrency goroutine number is hard-coded to 10. Performance regarding, its not a valid value on medium specs computers (usually 2 - 8 core not 10).

When you have a commit done by an author not having an email address, followed by a push to the repository hosted in Gogs, the method "newSignatureFromCommitline" causes a panic().

It is triggered at signature.go:30 which incorrectly assumes an email address is always entered.

panic: runtime error: slice bounds out of range [recovered]
panic: runtime error: slice bounds out of range

goroutine 1 [running]:
panic(0xd8d900, 0xc4200120e0)
/usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/urfave/cli.HandleAction.func1(0xc42026b940)
/home/vagrant/gopath/src/github.com/urfave/cli/app.go:478 +0x247
panic(0xd8d900, 0xc4200120e0)
/usr/local/go/src/runtime/panic.go:458 +0x243
github.com/gogits/git-module.newSignatureFromCommitline(0xc420170c65, 0x20, 0x59b, 0x6, 0xffffffffffffff01, 0x6)
/home/vagrant/gopath/src/github.com/gogits/git-module/signature.go:30 +0x489
github.com/gogits/git-module.parseCommitData(0xc420170c00, 0xdc, 0x600, 0xc420170c00, 0xdc, 0x600)
/home/vagrant/gopath/src/github.com/gogits/git-module/repo_commit.go:70 +0x3de
github.com/gogits/git-module.(*Repository).getCommit(0xc4204273e0, 0xa07ed8f8c22f15b8, 0xc698db97c4bfc470, 0xc698db97f4913a13, 0xf4913a13, 0x0, 0x0)
/home/vagrant/gopath/src/github.com/gogits/git-module/repo_commit.go:108 +0x40e
github.com/gogits/git-module.(*Repository).GetCommit(0xc4204273e0, 0xc420423770, 0x28, 0xa, 0x0, 0x0)
/home/vagrant/gopath/src/github.com/gogits/git-module/repo_commit.go:133 +0x88
github.com/gogits/gogs/models.PushUpdate(0x1b, 0xc4204241b0, 0xc, 0xc420411028, 0x6, 0xc42039ac27, 0xa, 0xc420426e20, 0x11, 0xc4204236e0, ...)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/update.go:140 +0x6ba
github.com/gogits/gogs/cmd.handleUpdateTask(0xc420422ea0, 0x24, 0xc420417000, 0xc42015ec00, 0xc42039ac27, 0xa, 0x0)
/home/vagrant/gopath/src/github.com/gogits/gogs/cmd/serve.go:111 +0x361
github.com/gogits/gogs/cmd.runServ(0xc420321040, 0x0, 0x0)
/home/vagrant/gopath/src/github.com/gogits/gogs/cmd/serve.go:279 +0xcd4
reflect.Value.call(0xd632e0, 0xef59f0, 0x13, 0xe5a833, 0x4, 0xc42026b900, 0x1, 0x1, 0x475128, 0xe42fe0, ...)
/usr/local/go/src/reflect/value.go:434 +0x5c8
reflect.Value.Call(0xd632e0, 0xef59f0, 0x13, 0xc42026b900, 0x1, 0x1, 0x0, 0xc42026b8e0, 0x47e056)
/usr/local/go/src/reflect/value.go:302 +0xa4
github.com/urfave/cli.HandleAction(0xd632e0, 0xef59f0, 0xc420321040, 0x0, 0x0)
/home/vagrant/gopath/src/github.com/urfave/cli/app.go:487 +0x1e0
github.com/urfave/cli.Command.Run(0xe5b2d7, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0xe8d556, 0x2f, 0x0, ...)
/home/vagrant/gopath/src/github.com/urfave/cli/command.go:186 +0xc2b
github.com/urfave/cli.(*App).Run(0xc420338000, 0xc42000c200, 0x4, 0x4, 0x0, 0x0)
/home/vagrant/gopath/src/github.com/urfave/cli/app.go:240 +0x611
main.main()
/home/vagrant/gopath/src/github.com/gogits/gogs/gogs.go:41 +0x321

AddOptions has a field called Pathsepcs instead of Pathspecs.

I use the gogs api for fetching repo content:

https://github.com/gogs/gogs/blob/master/internal/route/api/v1/api.go#L274-L276

I realized that for all executable files (mostly bash scripts), I get the following as the file content:

{"message":"the entry is not a blob","url":"https://github.com/gogs/docs-api"} 

Digging a little bit, I realized that the (t *Tree) Blob(subpath string, opts ...LsTreeOptions) (*Blob, error) func only returns Blob() if the entry is of type Blob:

// Blob returns the blob object by given subpath of the tree.
func (t *Tree) Blob(subpath string, opts ...LsTreeOptions) (*Blob, error) {
	e, err := t.TreeEntry(subpath, opts...)
	if err != nil {
		return nil, err
	}

	if e.IsBlob() {
		return e.Blob(), nil
	}

	return nil, ErrNotBlob
}

https://github.com/gogs/git-module/blob/master/tree_blob.go#L56

I think this is why the gogs conents api returns error message:

switch {
		case entry.IsBlob(), entry.IsExec():
			content.Type = "file"
			p, err := entry.Blob().Bytes()
			if err != nil {
				return nil, errors.Wrap(err, "get blob content")
			}
			content.Encoding = "base64"
			content.Content = base64.StdEncoding.EncodeToString(p)
			content.GitURL = fmt.Sprintf("%s/git/blobs/%s", repoURL, entry.ID().String())
....

https://github.com/gogs/gogs/blob/master/internal/route/api/v1/repo/contents.go#L87-L91

Can we make (t *Tree) Blob(subpath string, opts ...LsTreeOptions) (*Blob, error) func return contents for EntryExec and EntryBlob. @unknwon is this acceptable, or do you think that I got this all wrong and the fix should be somewhere else?

For directories with lot of (few thousand) files, https://github.com/gogits/git-module/blob/master/tree_entry.go#L160 time.Sleep(200*time.Millisecond) adds up.

By commenting it out, a 20s page rendering goes down to 1.6s (I was searching for solution for gogs/gogs#1518)

Is that sleep required?

The list of deprecated functions.