gonnagle / social-system Goto Github PK

Refactor the socket.io communication so that the client doesn't initiate the player specific updates (especially updating the hand).

Problem:

Currently there are cases where the socket.io isn't efficiently used and especially the flow with hands is far from optimal:

1. One of the players makes an action that changes the game state (plays cards for example)
2. Server sends the updated game state to all players
3. All players request their updated hands from the server on by one
4. Server returns everyone their hands individually (direct response to the specific client/socket action)

Proposed solution:

Implement tracking of players sockets (already tracking the "logged in" players and their cookie tokens so client id could be added to there. Then the flow go be simplified to be:

1. One of the players makes an action that changes the game state (plays cards for example)
2. Server sends the updated game state to all players
3. Server sends update to those players hands that have changed (if any)

Deploy to somewhere. For example Heroku?

Will add separate issue about creating CI/CD pipeline as well.

Pick up a suitable test framework and write some unit tests for the classes to cover at least the most important cases.

First version could be even just a simple text file or something else super lightweight to hold the info

Before first round there should be taxation with the following flow:

1. Multiple actions that can take place simultaniously:
   • Last player (lowest rank -> last in round) picks two (2) smallest cards (can be auto-picked as only one valid answer, but the player should still first see what they are giving out) to give out for the first player
   • Second last player picks their single (1) smallest card to give out for the second player
   • First player (highest rank -> first in round) picks any two (2) cards to give out for the last player
   • Second player picks any single (1) card to give out for the last player
2. Once all of those four players have committed their picks those will be delivered to to the target players and game is ready to start

Technical design:

• Add state taxation for the game
• Before game can start wait for players to pick the cards to hand out
• Each player should be able to send their pick separately to the server
• Once everyone has sent their cards the server will deal out the changed cards (update hands for those players) and change to the started state

Decide platform/tool to use and set the pipeline(s) up.

One option to investigate could: https://help.github.com/en/actions