gonzabrusco / tp2-tds Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 39 KB

TP2 de Testing de Software

C 100.00%

tp2-tds's People

Contributors

Watchers

tp2-tds's Issues

Se debería corregir el Copyright de los archivos

tp2-tds/test/test_leds.c

Line 3 in efb2e10

Las pruebas deberían probar una sola cosa

No hay ninguna razon para probar dos leds en la secuencia, con probar uno solo sería lo mismo.

tp2-tds/test/test_leds.c

Lines 124 to 135 in efb2e10

 void test_consultar_estado_led_prendido() { 

 // Enciendo dos leds (la funcion setup los inicializa apagados) 

 LedTurnOn(9); 

 LedTurnOn(3); 

 // Consulto el estado de los leds 

 unsigned int led1 = LedStatus(9); 

 unsigned int led2 = LedStatus(3); 

 TEST_ASSERT_EQUAL(1, led1); 

 TEST_ASSERT_EQUAL(1, led2); 

 }

Algunos problemas de formato, pero en general muy bien

El código de producción está impecable, muy bien refactorizado. Se agregaron las pruebas y código de producción mínimo exigido, tenes aprobado el TP2 con 9.

@marianofino @rafaeloliva

Se debería revisar el formato o la configuración de clang-format

tp2-tds/test/test_leds.c

Lines 36 to 37 in efb2e10

 /* === Headers files inclusions 

  * =============================================================== */

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	void test_consultar_estado_led_prendido() {
	// Enciendo dos leds (la funcion setup los inicializa apagados)
	LedTurnOn(9);
	LedTurnOn(3);

	// Consulto el estado de los leds
	unsigned int led1 = LedStatus(9);
	unsigned int led2 = LedStatus(3);

	TEST_ASSERT_EQUAL(1, led1);
	TEST_ASSERT_EQUAL(1, led2);
	}

	/* === Headers files inclusions
	* =============================================================== */