goodtrailer / daily-desktop Goto Github PK

Not sure how serialization works though.

Like #52, Unsplash tags are useful descriptors.

Sometimes requests just hiccup. That's just the nature of the internet, I guess.

Would be better at loosely "validating" URIs.

"Gets or sets" is super annoying and overly-verbose.

The directory handling is a bit of a mess.

• SerializeJsonDir -> SerializeDir
• Add an AssemblyDir field/property
• Add a DailyDesktopConstants static class
• Move all directory handling behavior from Desktop/Task into Core
• Pass everything as CL arguments to Task
• Keep a directories.json or something similar in the AssemblyDir

Should be file:///C:/..., the triple slash is necessary. This may be the case for the pixiv provider as well.

https://xkcd.com

I don't know how I didn't think about this until now. Wow.

Yep.

As described here, HttpClient is meant to be instantiated once. Whoopsies. Possibly related to #49.

https://www.natgeotv.com/ca/photo-of-the-day

Not sure why there's two National Geographic "photo of the day" collections, but the one over at nationalgeographic.com is pretty... prohibitive? It really makes clear that it doesn't want you to use the images without authorization, so I'll respect that. But the one at National Geographic TV seems more open access. The photos tend to have humans more often, but honestly that's pretty cool.

This is .NET convention: have a sync and async versions of methods, with async one suffixed with Async. This has already been done everywhere except DailyDesktopCore.

Investigate.

Allows for other effects (e.g. vignette), along with a probably faster blurring algorithm (superfastblur isn't actually very fast, despite scaling well. Using a sliding window method would run faster and still scale linearly).

Probably not useful anymore, and honestly just cumbersome to manage. Either choose synchronous, or choose asynchronous. Having both is just a nightmare.

Something to do with the cancellation token being triggered. I guess I forgot to handle cancellation tokens somewhere, and just let them throw. It's actually not a big deal here, because you can just click "Continue" on the exception popup, and the application continues (hooray for async applications!).

Seems like Bing changed their home page drastically

https://time.com/tag/photo-of-the-day/

Not super special but seems like decent filler.

Not really necessary, and over-complicates logic.

Might be that the cancellation token is canceling too early. Maybe needs 10 seconds? Seems oddly slow, though.

Wallpaper JSON could probably benefit from the same system.

As explained in #20:

DeviantArt test has been (erroneously?) failing for a while now, and it's getting annoying. Will have to look into the 403 error.

Could be useful for something like Deviant Art or Pixiv or something. For example, there could be different "modes" for Pixiv: daily ranking (current implementation), specific artists, etc.

Or at least, refactor all the Task Scheduler behavior into a separate class, and have the Core class just hold configs and handle dependency injection. This would allow removal of a lot of "forwarding" methods and duplicate async/sync methods. Also, having a single monolithic master class just sucks.

This is relatively rare and hard to reproduce. It just seems to happen for some images, and I have no idea why. Potentially related to #21.

Maybe this is the cause of the random massive lag spikes.

https://www.nytimes.com/column/learning-whats-going-on-in-this-picture

Seems like it could be pretty fun, since it's kinda like a challenge.

This prevents the "file is open in DailyDesktop.Desktop" pop-up (which is especially annoying with async stuffs).

A lot of illustrations don't have a proper description, but they always have a bunch of descriptive tags.

https://earthobservatory.nasa.gov/topic/image-of-the-day

This one is really interesting. The descriptions are absolutely awesome and ridiculously detailed, and the image links are pretty easy to access. This one has so much potential.

https://apod.nasa.gov/apod/astropix.html

Seems to be super consistent and stable, so it should be really easy to regex and implement.