goofball222 / murmur Goto Github PK

Murmur 1.3.1 has security fixes that would be very helpful to keep one's server secure. Currently the Docker container contains Murmur 1.3.0.

I've tried providing -supw MyPassword in the MURMUR_OPTS environment variable, however the entrypoint script puts the supplied options at the beginning of the argument chain (presumably so that the ones provided in the script take precedence?) but this causes an error from murmur, as it requires that -supw is the last argument.

I'd be glad to create a PR to add an additional environment variable at the end of the chain if that's helpful, but if there's a better way, please let me know.

• OS/distribution version:

No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.3 LTS
Release:	18.04
Codename:	bionic

• Docker version:

Client: Docker Engine - Community
 Version:           19.03.1
 API version:       1.40
 Go version:        go1.12.5
 Git commit:        74b1e89
 Built:             Thu Jul 25 21:21:05 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.1
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.5
  Git commit:       74b1e89
  Built:            Thu Jul 25 21:19:41 2019
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.2.6
  GitCommit:        894b81a4b802e4eb2a91d1ce216b8817763c29fb
 runc:
  Version:          1.0.0-rc8
  GitCommit:        425e105d5a03fabd737a126ad93d62a9eeede87f
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

• Labels from container:

                "org.label-schema.build-date": "2020-04-02T18:35:03Z",
                "org.label-schema.license": "Apache-2.0",
                "org.label-schema.name": "Murmur Server",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.url": "https://github.com/goofball222/murmur",
                "org.label-schema.vcs-ref": "9aa0ee1",
                "org.label-schema.vcs-url": "https://github.com/goofball222/murmur.git",
                "org.label-schema.vendor": "The Goofball - [email protected]",
                "org.label-schema.version": "1.3.0",

• Please provide the following information:

  • OS/distribution version (command for your OS may differ):
    unRAID 6.8.3

  • Docker version:
    Docker version 19.03.5, build 633a0ea838

  • Labels from container:

 "Labels": {
                "org.label-schema.build-date": "2020-04-02T18:35:03Z",
                "org.label-schema.license": "Apache-2.0",
                "org.label-schema.name": "Murmur Server",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.url": "https://github.com/goofball222/murmur",
                "org.label-schema.vcs-ref": "9aa0ee1",
                "org.label-schema.vcs-url": "https://github.com/goofball222/murmur.git",
                "org.label-schema.vendor": "The Goofball - [email protected]",
                "org.label-schema.version": "1.3.0"

* Details on how to reproduce the trouble, if available:

Basicaly I have issues with certificates from the LetsEncrypt docker not being read by Murmur.

It seems that the docker can't read a symlinked cert, as it comes up with these errors:

2020-04-12T20:32:33.673 <docker-entrypoint> WARN - SSL: missing '/opt/murmur/cert/privkey.pem', murmur will use self-signed SSL certificate 2020-04-12T20:32:33.674 <docker-entrypoint> WARN - SSL: missing '/opt/murmur/cert/fullchain.pem', murmur will use self-signed SSL certificate

I can copy and paste the certs into the murmur/cert folder and it works fine, but then the certs won't get updated.

I have tried mapping /opt/murmur/cert directly to where the certs are stored in LetsEncrypt, but the certs are originally called privkey1.perm and fullchain1.perm in the LetsEncrypt docker, and therefore I get the same error.

I realise this is on unraid and may not be what you are use to, but it should all work the same. If I have missed out any information then please let me know.

Thanks in advance!

I'm trying to run with custom UID and GID but I get the following error on startup:

<docker-entrypoint> INFO - Setting custom murmur UID/GID: UID=1000, GID=1001
/usr/local/bin/docker-entrypoint.sh: line 92: usermod: command not found

Is there something special I need to do besides specifying PUID and PGID in my compose file?

No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial

Docker version 17.12.0-ce, build c97c6d6

"org.label-schema.build-date": "2018-03-29T22:49:23Z",
"org.label-schema.license": "Apache-2.0",
"org.label-schema.name": "Murmur Server",
"org.label-schema.schema-version": "1.0",
"org.label-schema.url": "https://github.com/goofball222/murmur",
"org.label-schema.vcs-ref": "91fddfa",
"org.label-schema.vcs-url": "https://github.com/goofball222/murmur.git",
"org.label-schema.vendor": "goofball222",
"org.label-schema.version": "1.2.19"

OS

Distributor ID: Ubuntu
Description:    Ubuntu 21.04
Release:        21.04
Codename:       hirsute

Docker

Docker version 20.10.10, build b485636

Labels

                "org.opencontainers.image.created": "2021-06-17T22:37:49.252Z",
                "org.opencontainers.image.description": "Murmur (Mumble) Server",
                "org.opencontainers.image.licenses": "Apache-2.0",
                "org.opencontainers.image.revision": "2ea7e1759fc0a9bbebca6ba59797837fd81c6283",
                "org.opencontainers.image.source": "https://github.com/goofball222/murmur",
                "org.opencontainers.image.title": "Murmur (Mumble) Server",
                "org.opencontainers.image.url": "https://github.com/goofball222/murmur",
                "org.opencontainers.image.vendor": "The Goofball - [email protected]",
                "org.opencontainers.image.version": "1.3.4"

Compose file

version: '3'

services:
  murmur:
    image: goofball222/murmur
    container_name: murmur
    ports:
      - 64738:64738/tcp
      - 64738:64738/udp
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - ./cert:/opt/murmur/cert
      - ./config:/opt/murmur/config
      - ./data:/opt/murmur/data
      - ./log:/opt/murmur/log
    environment:
      - TZ=UTC

How to reproduce

Simply run a docker-compose up -d for a docker-compose.yml file with the above mentioned contents.

Expected results

The container starts and continues to run.

Actual results

The container exits immediately with the following log:

standard_init_linux.go:228: exec user process caused: exec format error

• OS/distribution version:

LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description:    CentOS Linux release 7.9.2009 (Core)
Release:        7.9.2009
Codename:       Core

• Docker version:

Docker version 1.13.1, build 7d71120/1.13.1

• Details:
  When running docker container with attached volumes, the mumur executable did not appear to write to the log file defined in murmur.ini.
  Logging appears to be restored if modifications to launch parameters are made, taking murmur.x86 out of the foreground as follows:
  Removal of the "-fg" launch parameter contained in MURMUR_OPTS env variable in /usr/local/bin/entrypoint-functions.sh

MURMUR_OPTS="${MURMUR_OPTS} -v -ini ${CONFIGDIR}/murmur.ini"

Hello,
I'm currently trying to use your image with a mysql database but this specific function does not allow me to do it

Could you avoid overwriting this variable or finding another way to check it beforehand so that actual database names can be used?
Currently this prevent any third-party database to be used.
Best,

Mumble 1.3.0 was released: https://github.com/mumble-voip/mumble/releases/tag/1.3.0

stable and rc tags should be updated and maybe a new release-1.3.0 tag should be created.

Reporting bugs/issues

• When reporting a bug/issue:

  • Ensure that you are using the latest release. true
  • Revert any custom modifications or environment varibles to insure they're not the cause. true

• Please provide the following information:

  • OS/distribution version (command for your OS may differ):

  user@host:~$ lsb_release -a
  No LSB modules are available.
  Distributor ID: Debian
  Description:    Debian GNU/Linux 9.8 (stretch)
  Release:        9.8
  Codename:       stretch
  

  • Docker version:

  user@host:~$ docker --version
  Docker version 18.09.5, build e8ff056dbc

  • Labels from container:

  user@host:~$ docker inspect goofball222/murmur:<tagname>
  ...
              "Labels": {
              "org.label-schema.build-date": "2019-04-01T02:00:28Z",
              "org.label-schema.license": "Apache-2.0",
              "org.label-schema.name": "Murmur Server",
              "org.label-schema.schema-version": "1.0",
              "org.label-schema.url": "https://github.com/goofball222/murmur",
              "org.label-schema.vcs-ref": "107157b",
              "org.label-schema.vcs-url": "https://github.com/goofball222/murmur.git",
              "org.label-schema.vendor": "The Goofball - [email protected]",
              "org.label-schema.version": "1.2.19"
          }
  ...

  • Details on how to reproduce the trouble, if available:

I want to use some Let's Encrypt certs for this service. I mount them in readonly mode and I only mount the ones needed for the murmur server domain. When mounted on /opt/murmur/cert, the chown fails because it's a readonly filesystem. The certificates shouldn't be modified, not even the permissions, because murmur just needs to be able to read them.

A possible solution would be allowing the user to set the CERTDIR environment variable to somwhere outside of /opt/murmur and mount the certificates there. Then, you could run the image like this:

/usr/bin/docker run --rm --name "murmur" \
-e 'PUID=1000' -e 'PGID=1000' \
-e "CERTDIR=/etc/letsencrypt/live/[domain]" \
-v "/data/murmur/conf":/opt/murmur/config \
-v "/data/murmur/data":/opt/murmur/data \
-v "/data/murmur/log":/opt/murmur/log \
-v '/etc/localtime:/etc/localtime:ro' \
-v /etc/letsencrypt/live/[domain]:/etc/letsencrypt/live/[domain]/:ro \
-v /etc/letsencrypt/archive/[domain]:/etc/letsencrypt/archive/[domain]/:ro \
-p "64738:64738/tcp" \
-p "64738:64738/udp" \
"goofball222/murmur:latest"

Note mounting live and archive is needed for the symlinks to work, a simpler approach would be to just mount the whole /etc/letsencrypt directory.

Hello thanks you for your project.
I have a question. How can I add new user to Sqlite. Using command line or create new row on database. Thanks you.

I use mariadb as my database but the f_setup function always overwrites the database variable. I haven't found a way around this. setting ini in the MURMUR_OPTS gets overwriten so I can't specify another ini or anything. I don't know the best way to change the script. Maybe touch a setup file or something that gets checked and if it exists setup isn't run? Or a ENV variable that can be set to not run it?

Need to update to Mumble Server 1.4.230.