Comments (5)
To summarise this morning's discussion at the developers call: I think we agreed due to the performance concerns on loading npm packages into worker contexts, it's best to give application the chance to frontload such operations. as a result i think having this as a separate util make sense, as opposed to letting the knowledge manager handle this at the point of extraction.
from android-fhir.
from android-fhir.
@jingtang10 @joiskash @owais-vd check this out
from android-fhir.
I suppose my objection to the above design is how do the applciations maintain the npm packages? do we expect app to store and manage the npm packages and call the knowledge manager API with them?
i think the npm packages should be managed by the knowledge manager - and that's the knowledge manager's job really. so that the api should be adapted so that the application only needs to pass the ids of the npm packages to the knowledge manager for it to generate worker context containing multiple npm packages.
@joiskash, did you manage to discuss this at today's the wg2 call? an alternative approach would be for this information not to be provided by the application, but for the sdc library to have a direct dependency on the knowledge manager which will return a worker context containing all the npm packages stored locally. this means that the application doesn't have a say on which npm packages to use, but the km simply creates a worker context that uses all available npm packages.
from android-fhir.
Yes I did discuss. The conclusion was that it is safe to assume that IGs will not have structure map with conflicts. But on the other side, if apps are designed to serve dynamic content based on Patient and usecase, then it might be better to have a way to load contexts with specific IGs. I think in either way, keeping the knowledge manager responsible of handling and managing the NPM packages makes sense to me. @dubdabasoduba what do you think?
from android-fhir.
Related Issues (20)
- erroreneous docs - search method documentation
- Improve FhirEngine Search performance for sorting HOT 7
- 'SELECT' queries sometimes take too long to run HOT 6
- Custom Search Parameter does not Consider in x-fhir-query HOT 1
- Wrap FHIREngine API calls with "withContext(Dispatcher.IO) {}"
- Sync fails with 'too many SQL variables' in select HOT 3
- SQLite crashes with 'Expression tree is too large (maximum depth 1000)' HOT 3
- Update the repeatedGroup ui. HOT 3
- Add Distinct in SQL query instead of kotlin function in search query
- Previous button shows up on the first page
- Cookie Support in Headers through networkConfiguration HOT 7
- Snapshot Packages are not published or visiblie HOT 5
- Update documentation for custom ui components
- Dependabot should not add google/android-fhir group as reviewers to its PRs HOT 2
- Unknown owner on line 11: make sure @santosh-pingle exists and has write access to the repository HOT 1
- Crash when using QuestionnaireFragment.Builder.setShowNavigationInDefaultLongScroll
- Repeated Group: Anomalous behaviour of enableWhen expressions in a repeated group HOT 7
- Upon deleting a repeatedGroup answer, the other repeatedGroup answers are also reset. HOT 1
- UI/UX Design: The name for a specific field be equidistant from its intended field and another field HOT 2
- UI/UX Design: Warning text (i.e. text that are nudging clinical decision guideline to users) looks visually similar with other fields HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-fhir.