Giter VIP home page Giter VIP logo

Comments (9)

aditya-07 avatar aditya-07 commented on June 4, 2024 1

@aditya-07 are you available for us to have a debugging session? If yes, let me know when I can set one up.

Yes, that sounds like a good idea. Feel free to setup one today (Wednesday) or tomorrow between 11am-6pm IST.

from android-fhir.

allan-on avatar allan-on commented on June 4, 2024

Additional context

  • As mentioned above when resources are updated and updateIndicesForResource() executed, there'll be multiple DateTimeIndexEntity entries for that resource.

image

  • In this additional example, duplicate resource records are returned from the getIncludeQuery that's used in searchForwardReferencedResources()
    This is a result of the LEFT JOIN DateTimeIndexEntity

image

from android-fhir.

MJ1998 avatar MJ1998 commented on June 4, 2024

Hey @SebaMutuku. You are probably right in why duplicate resources are being returned in search - because of duplicate DateTimeIndexEntity records. However, I am not able to observe duplicate DateTimeIndexEntity records when updating same resource locally.

Can you provide steps to replicate it ?
Is it happening when the resource is synced and then one is making local changes ?

from android-fhir.

SebaMutuku avatar SebaMutuku commented on June 4, 2024

Hello @MJ1998? attached is the SQLite DB for patient shown on the screenshot below
image

Patient ID 119c3d24-123b-4719-b39d-5e9be05f8e85
Check the record on LocalChangeEntity and to answer your question, this only happens on local changes. When you sync data to the server, the issue is solved.
resources_duplication_db.zip

from android-fhir.

MJ1998 avatar MJ1998 commented on June 4, 2024

LocalChangeEntity has one record per resource. Do you mean to check DateTimeIndexEntity table ?

from android-fhir.

SebaMutuku avatar SebaMutuku commented on June 4, 2024

@MJ1998 yes, that's the entry causing duplication. If you check it on this line https://github.com/google/android-fhir/blob/master/engine/src/main/java/com/google/android/fhir/search/MoreSearch.kt#L58 you will see what the query returns

from android-fhir.

aditya-07 avatar aditya-07 commented on June 4, 2024

@SebaMutuku @allan-on Can you please add the Search Query passed into the fhirEngine.search<Resource>(search).

Also, can you specify the engine version that's being used.

from android-fhir.

SebaMutuku avatar SebaMutuku commented on June 4, 2024

@aditya-07 are you available for us to have a debugging session? If yes, let me know when I can set one up.

from android-fhir.

SebaMutuku avatar SebaMutuku commented on June 4, 2024

@aditya-07 here's the sample database we have had a look at together
resources_db.zip

from android-fhir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.