Giter VIP home page Giter VIP logo

codeu_project_2018's Issues

User controlled redirection

Use user-controlled values directly as redirect addresses on lines 112 and 120

codeu_project_2018/src/main/java/codeu/controller/ConversationServlet.java

Lines 102 to 120 in 0c129ab

String conversationTitle = request.getParameter("conversationTitle");
if (!conversationTitle.matches("[\\w*]*")) {
request.setAttribute("error", "Please enter only letters and numbers.");
request.getRequestDispatcher("/WEB-INF/view/conversations.jsp").forward(request, response);
return;
}
if (conversationStore.isTitleTaken(conversationTitle)) {
// conversation title is already taken, just go into that conversation instead of creating a
// new one
response.sendRedirect("/chat/" + conversationTitle);
return;
}
Conversation conversation =
new Conversation(UUID.randomUUID(), user.getId(), conversationTitle, Instant.now());
conversationStore.addConversation(conversation);
response.sendRedirect("/chat/" + conversationTitle);

Reflective XSS

The username is not secure and is used in the JSP

codeu_project_2018/src/main/java/codeu/controller/LoginServlet.java

Lines 69 to 87 in 0c129ab

String username = request.getParameter("username");
String password = request.getParameter("password");
if (!userStore.isUserRegistered(username)) {
request.setAttribute("error", "That username was not found.");
request.getRequestDispatcher("/WEB-INF/view/login.jsp").forward(request, response);
return;
}
User user = userStore.getUser(username);
if (!BCrypt.checkpw(password, user.getPasswordHash())) {
request.setAttribute("error", "Please enter a correct password.");
request.getRequestDispatcher("/WEB-INF/view/login.jsp").forward(request, response);
return;
}
request.getSession().setAttribute("user", username);
response.sendRedirect("/conversations");

<a>Hello <%= request.getSession().getAttribute("user") %>!</a> in about.jsp,chat.jsp,conversations.jsp,index.jsp,login.jsp,register.jsp

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.