[Geometry tasks] Rotating device causes app to force quit about ground-android HOT 5 OPEN

Makes sense. I'll try to figure out a workaround where we don't have to pass the view models via constructor. Thanks for the help!

from ground-android.

@shobhitagarwal1612 Do you have cycles to investigate? FYI @jcqli to ensure this gets triaged appropriately.

from ground-android.

Looking into it now.

from ground-android.

I tried looking into it but haven't found a solution yet. This issue is happening with all map type tasks and not just draw area task. We create a map fragment inside the task fragment. This works fine when opening the data collection fragment but fails when rotating the device.

Do you have any ideas?

from ground-android.

The problem appears to be that there's no noarg constructor of the data collection fragments. The fragments should be able to be recreated by their parents on config change, so the viewModel should not be getting passed into the constructor. Instead, the Fragment should try to get the viewModel using the ViewModelFactory, ideally through helper getViewModel.

@shobhitagarwal1612 Wdyt?

from ground-android.