Comments (14)
Happened exactly the same thing to me on this MR / commit as well: https://reviews.llvm.org/D112374
A big patch with a lot of test churn got reverted, which is time consuming to maintain out of tree.
I got no prior notification, the project affected (lldb) does no pre-commit testing, and I have been spending a lot of time trying to even get the project to build correctly and run that test on my machine.
That project requires many dependencies and the build system setup is quite fragile... I completely agree it's unreasonable.
Reading the logs from the bot test failure, I would say I am 99% confident the test expectation change required is identical to many others in the commit.
from llvm-premerge-checks.
as I reading initial post - Aaron is asking to start lldb / libc++ pipelines when clang is updated. This is possible to configure.
from llvm-premerge-checks.
Thank you for the report! Looking on dependency setup: we already have a logic to run tests on all affected projects. The only issue is that lldb was excluded from being executed as it have been constantly failing or flaking. Do you know if situation has improved?
from llvm-premerge-checks.
Do you know if situation has improved?
I honestly have no idea regarding lldb. I know I've seen at least one test of theirs that's been flakey (from watching bots in IRC), but I would argue that such tests should be disabled regardless (if the test is so unstable we consider not adding the entire test suite to precommit CI, it's a low value test).
from llvm-premerge-checks.
Is there an update on this request. I would love Clang to test libc++ since we had some Clang changes affecting libc++ recently. Do you need assistance to setup testing libc++ with Clang?
from llvm-premerge-checks.
This was done in https://reviews.llvm.org/D137759, but we would really like to move from our own libc++ runners to Clang-dedicated runners. @metaflow how do you get your clang-dedicated runners? Could we get some with a specific Docker image installed on them?
from llvm-premerge-checks.
yes, we use a docker image containers/agent-builkite-debian. I have not updated them in a while..
from llvm-premerge-checks.
@ldionne after re-reading comments I think I misunderstood you. Do you want to run a new set of agents with a different setup?
from llvm-premerge-checks.
why it's not possible to use the same setup for "normal" linux and libc++?
from llvm-premerge-checks.
as I reading initial post - Aaron is asking to start lldb / libc++ pipelines when clang is updated.
That's correct @metaflow -- my goal is to alert folks working on Clang when we've made a change that impacts libc++ or lldb before the author commits the patch.
from llvm-premerge-checks.
I think that's what you need ⬆️ - now when clang is touched libcxx / libcxxabi projects will also be checked. That does not affect behavior of libcxx runners
from llvm-premerge-checks.
Thank you! Is it possible to also do lldb as well?
Also, is the FIXME comment still accurate there? (# FIXME: not sure about 'libcxx' and 'libcxxabi'
)
from llvm-premerge-checks.
added lldb and removed fixme
from llvm-premerge-checks.
Thank you!
from llvm-premerge-checks.
Related Issues (20)
- buildkite build premerge-checks 98677 HOT 5
- Proposal for new pre-merge check: Enforce library layering constraints
- Precommit CI is broken again (libomptarget) HOT 4
- Precommit says bazel is failing, looks to be a config issue
- git-clang-format crash on x64_debian
- Windows Precommit CI was not updated for the recent base LLVM language version change? HOT 2
- Precommit CI appears to be entirely broken HOT 4
- clang-format debian clang pre-commit failure for changes on libcxx.
- Patch failure due to git issue
- buildkite build premerge-checks 141874 HOT 1
- The Buildkite <-> Phabricator bridge can ignore failed tests in the "unit tests" view of Harbormaster HOT 9
- buildkite build diff-checks 161247 HOT 1
- [AIX][32, 64 bit]Buildkite premerge checks for AIX 32, 64 bit not working due to insufficient space on filesystem HOT 5
- [libcxx] Generated output step is failing because of IndentationError HOT 2
- "create branch" steps takes > 15min
- libc++ CI being skipped (randomly?) but Phabricator reports a success HOT 10
- timeouts are reported as success HOT 3
- [libcxx] Generated Output step of libcxx fails on premerge checks HOT 3
- buildkite build phabricator-run-tests 174016 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from llvm-premerge-checks.