Comments (9)
@ldionne I have updated the script that generates the report - now it should fail on anything that is not "passing" (previously we were only considered "pass" or "fail" as interesting), it also should correctly process recursive builds and report all failing tests. Not sure if reporting all failed jobs will be too verbose, please ping me if it is going out of hand.
from llvm-premerge-checks.
I will take a look on Monday.
from llvm-premerge-checks.
Hi @ldionne , unfortunately I didn't have a chance to look at it this week (on a bright side we solved one issue with win machines with @mstorsjo in #440) . I am also leaving for 2 week vacation.
@movsic maybe you want to exercise your buildkite knowledge? 😉
from llvm-premerge-checks.
This just happened again! https://buildkite.com/llvm-project/libcxx-ci/builds/22675 is skipped, but https://llvm.org/D143914 shows the pre-merge checks as passed. I think there's a lot of value in fixing this TBH, otherwise we don't know whether we can rely on a green checkmark from the Phabricator UI.
from llvm-premerge-checks.
On the surface it seems that the issue is with the part that parses the results and passes back to phabricator.
@ldionne will it be better to not report any of the results back to phabricator and just report that "there are failures - go figure"? (that will be the quickest option).
Otherwise I am looking into properly parsing the results.
from llvm-premerge-checks.
@ldionne I am also confused by
In particular, we had some tests in the no-exceptions CI job that were never reported in the Harbormaster view
while in...
in https://reviews.llvm.org/harbormaster/unit/220338/ you posted there are 4 failures reported by "no exceptions" - exactly ones in https://buildkite.com/llvm-project/libcxx-ci/builds/20939#0186fc1a-7a90-43ca-b8bb-53b32fe23a28
from llvm-premerge-checks.
On the surface it seems that the issue is with the part that parses the results and passes back to phabricator.
@ldionne will it be better to not report any of the results back to phabricator and just report that "there are failures - go figure"? (that will be the quickest option).
Yes, honestly I think that's what I would do.
@ldionne I am also confused by
In particular, we had some tests in the no-exceptions CI job that were never reported in the Harbormaster view
while in...in https://reviews.llvm.org/harbormaster/unit/220338/ you posted there are 4 failures reported by "no exceptions" - exactly ones in https://buildkite.com/llvm-project/libcxx-ci/builds/20939#0186fc1a-7a90-43ca-b8bb-53b32fe23a28
Hmm, you are right, I'm not sure what I was referring to anymore. The noexceptions Lit tests failing do seem to be reported faithfully. However, some other jobs are failing before we even get to the Lit tests and those results are not reported -- so IMO the right path here would be to not attempt to report anything and just provide a quick link to the Buildkite job itself, where people can see the problems directly.
from llvm-premerge-checks.
@ldionne is it better now?
from llvm-premerge-checks.
I think it is, thanks!
from llvm-premerge-checks.
Related Issues (20)
- buildkite build premerge-checks 98677 HOT 5
- Proposal for new pre-merge check: Enforce library layering constraints
- Please add libc++ and lldb to the precommit CI pipeline for Clang HOT 14
- Precommit CI is broken again (libomptarget) HOT 4
- Precommit says bazel is failing, looks to be a config issue
- git-clang-format crash on x64_debian
- Windows Precommit CI was not updated for the recent base LLVM language version change? HOT 2
- Precommit CI appears to be entirely broken HOT 4
- clang-format debian clang pre-commit failure for changes on libcxx.
- Patch failure due to git issue
- buildkite build premerge-checks 141874 HOT 1
- buildkite build diff-checks 161247 HOT 1
- [AIX][32, 64 bit]Buildkite premerge checks for AIX 32, 64 bit not working due to insufficient space on filesystem HOT 5
- [libcxx] Generated output step is failing because of IndentationError HOT 2
- "create branch" steps takes > 15min
- libc++ CI being skipped (randomly?) but Phabricator reports a success HOT 10
- timeouts are reported as success HOT 3
- [libcxx] Generated Output step of libcxx fails on premerge checks HOT 3
- buildkite build phabricator-run-tests 174016 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from llvm-premerge-checks.