Comments (4)
chhamilton
commented on July 28, 2024
Bruce Dawson suggested that we should never wrap the original exception, even if we've augmented the crash report with additional information. Wrapping page violations / null pointer dereferences / etc actually hides the underlying error, and they all bucket under the SyzyASAN UNKNOWN crash type. I think that's a great follow-up for plmonette's CL.
from syzygy.
sebmarchand
commented on July 28, 2024
Does that mean that we should maybe disable the unhandled exception filter ?
from syzygy.
chhamilton
commented on July 28, 2024
No, we still want the filter to be able to analyze memory and add information about memory corruption, etc. But we don't need to wrap the exception record with our own one in this case.
from syzygy.
chhamilton
commented on July 28, 2024
This has been partially addressed by plmonette's CL. However, to close this let's not wrap UnhandledExceptionFilter bugs at all, but rather only augment them.
from syzygy.
Related Issues (20)
- Crash reporting policy code needs refactoring HOT 4
- Symbolization issue in agent_logger
- PeAndPdbAreMatched returns false on x64 binaries HOT 9
- Security bug in documentation, and old documentation still in use HOT 2
- Update instrumentation instructions for gn HOT 2
- Official win-asan build failing
- ClusterFuzz tripping DCHECKs in SyzyASAN RTL HOT 3
- Consistent shutdown crash on recent canaries.
- syzyasan needs updating to support VS 2017 generated binaries HOT 7
- How SyzyASAN report more errors than just oneοΌ HOT 2
- Flaky Test in Syzygy Asan HOT 1
- CRT function replacement failures should be able to fail build HOT 1
- Errant assert in agent::asan::TestMemoryRange?
- Faults in UnhandledExceptionFilter go to WER
- Unable to read SEH handler table. HOT 3
- Errors in instrument usage string
- Instrumentation fails - Unexpected data label at offset HOT 1
- can't compile due to missing python26 dependancy HOT 2
- syzygy has serveral problems in WinSDK 17134 and clang compiler builds project
- Security Policy violation Binary Artifacts HOT 88
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from syzygy.