Giter VIP home page Giter VIP logo

Comments (7)

JoeByte avatar JoeByte commented on August 16, 2024 2

Full agree with janhartigan

  1. the google api lib is too large , about 16.8M but i just wanna use the simple function
  2. the composer update waste much of my time. Here is China, it`s not ~15-30 seconds per composer update, It waste too many minutes per composer update

from google-api-php-client-services.

highstrike avatar highstrike commented on August 16, 2024 1

Would really like to see an update on this.
My composer has to download 7000+ files just for this code here:

// verify validity of token
$client = new Google_Client(array_merge(['jwt' => $jwt], $config));
$payload = $client->verifyIdToken($request->getData('id_token'));
if(!$payload)
    return false;

This is quite silly and a MASSIVE overkill just like OP wrote.

from google-api-php-client-services.

janhartigan avatar janhartigan commented on August 16, 2024

This is seriously an embarrassing reality of this repository. Google libraries are usually pretty terrible, tho, so it's not super surprising.

from google-api-php-client-services.

bshaffer avatar bshaffer commented on August 16, 2024

Thank you for voicing your opinions here. I fully agree.

Because Composer requires a repository per package, we'd have to maintain 140+ repositories to allow for each service to be used individually. This is actually not a big deal IMHO, it could be automated and would be well worth the investment ford what we'd gain in usability. But the extra overhead and is why this hasn't been done yet.

from google-api-php-client-services.

janhartigan avatar janhartigan commented on August 16, 2024

@bshaffer you could also look into subtree splits. Considering the number of repositories, it may prove unwieldy, but that way you get a repository per package, but you only have to maintain the main monolithic repo. Laravel does this where the main package is laravel/framework but they have a bunch of subsplits for the various Illuminate subdirectories (https://github.com/illuminate/http for example).

You can see how they used to do this here:
https://github.com/laravel/framework/blob/5.1/build/illuminate-split.sh

And a post about how it is done here:
https://www.tomasvotruba.cz/blog/2017/01/31/how-monolithic-repository-in-open-source-saved-my-laziness/

Sorry for the snarky comment above, but in my experience complaining about things to Google is about as effective as shouting at a hurricane. If you guys don't mind simply having an extra 150 repositories, the extra build legwork by you guys could save everyone who uses this repository roughly ~15-30 seconds per composer update (depending on machine specs).

from google-api-php-client-services.

janhartigan avatar janhartigan commented on August 16, 2024

More information here about subsplit: https://github.com/dflydev/git-subsplit

from google-api-php-client-services.

mattwhisenhunt avatar mattwhisenhunt commented on August 16, 2024

Thanks everybody for your input. We are moving newer libraries in this direction as seen in the GCP libraries

Since it is not a change we are going to make to this repo, I am closing this issue.

from google-api-php-client-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.