googlearchive / guitar-tuner Goto Github PK

View Code? Open in Web Editor NEW

832.0 832.0 110.0 185 KB

A web-based guitar tuner

Home Page: https://guitar-tuner.appspot.com/

License: Apache License 2.0

JavaScript 68.79% HTML 10.64% CSS 18.11% Python 2.46%

guitar-tuner's Introduction

Guitar Tuner

A sample web app that lets you tune a guitar. It uses ES6 classes (via Babel) and Polymer 1.0.

See the site here

Running the site locally

Download the Google App Engine SDK for Python. Grab the Launcher, and install it.
npm install -g gulp
git clone https://github.com/GoogleChrome/guitar-tuner
cd guitar-tuner
npm i
gulp

If you get an error about lib-sass, you will need to get a newer version of gulp-sass:

throw new Error('`libsass` bindings not found. Try reinstalling `node-sass`?');

The error is thrown if your version of Node is newer than 0.12 or so.

Open package.json and change the gulp-sass version to 2.1.0 or newer, i.e. "gulp-sass": "^2.1.0"
rm -rf node_modules/
npm i
gulp

Once the build has finished, you can boot the GAE Launcher and choose File -> Add Existing Application... and point it at the guitar-tuner folder.

Start the application, and visit the URL indicated by the port, i.e. http://localhost:8080 (N.B. you do not the admin port).

License

Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the “License”); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an “AS IS” BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

Please note: this is not a Google product

guitar-tuner's People

Contributors

Stargazers

Watchers

Forkers

docworld gabrielduque asolfre fathermother digitarald andreasloukakis greenido iplanwebsites fclaeys tmescic briansipple alihalabyah zoltanseer toddhodes nopakorn karimabdul jimlyndon dmitryolkhovoi eliot-akira oeohomos elijahlynn beaufortfrancois imclab agarciadelrio laterdude jordietyahii lauratownsend jeffposnick jonasantonelli rodericday benhjt beingsane brianedsauer calvincoxiii rockykitamura kleopatra999 wangzhihao lychees andrew--grant letsila xniko sato-shi lmorillas mmmika lukejacksonn voiddeveloper joncv ibrahimozturkme alex-milanov kyr0 maxime-michel had3s13 ctnswb hlaingwinhtut oluwanisola acadia1337 samuelteixeiras newrebel gpsbird csuchocki nattaponra hurely jimihford grassgod sixteentons chz100p wangmengliang akashpkumar stanwmusic nawalgupta jaylinlee clydekuo henrywoo osgioia banjerluke stereoraj pantazis bonniss ilyapapelishvili noise-labs johneidahou mhartington mberger75 ketangupta34 luisoms googtech anubhav-developr jiewa-light santamarta4life gribblee themanfromearth1 lucapruneti nay-gupta isontheline ryuawata evzaboun archive-42 andreteixeira1998 deepmatrix sergeyyenin

guitar-tuner's Issues

Why is there no test suite included?

Just wondering...

Thanks bro it's so useful to guitar beginner, but throw a error info when I try to run it.

This error information be throwed as below when I try to run this command in bash terminal : gulp

Node Sass does not yet support your current environment: Windows 64-bit with Unsupported runtime (64)

Change A# to Bb

I'm a snob I know. Change the A# to Bb. Tuner is great.

Toaster inlined twice

I've noticed that Toaster.js module is bundled (inlined) twice during the build - in audio-processor.html and in guitartuner-core.js. I understand it's not important for this app, however it's a showcase for Polymer-based apps in general. Do you think it makes sense to move all shared modules across the bundles into a separate file?

Noob here

How do I set this up on my localhost? Could you guide me like a html/css/js noob.

Beautiful! One UX suggestion...

First of all, great work. This is one of those "Really? The web can do that?" apps so thanks!

One minor UI tweak: when you hit the note dead-on, it would be nice if the moving array changed color (to green perhaps). I realize you provide the same info when you change the up/down arrow to a check mark but that requires the user to avert their attention to a different location on the screen. I would leave the arrow/check as consider adding the color coding to provide better visual continuity for arrow watchers.

ES6 pattern for polymer elements does not work with data-binding system

The pattern of creating properties in created does not work with polymer's data binding system.

For example, if you defined a <dom-module> and data-bound to tolerance, the console would throw an error in the console saying this is undefined.

<dom-module id="tuning-instructions">
  <template>
    <span>{{tolerance}}</span>
  </template>
</dom-module>

Instead, properties should be setup in properties:

get properties() {return {
  tolerance: {
    type: Number,
    value: 0.006
  }
};}

The setup currently works because you didn't use data binding features in the DOM.

Example: http://jsbin.com/mugewudime/edit?html,output

Unable to access the microphone

Hi, thanks for your job~ I try this on wechat and my phone native browser,
It cannot work and a toast: Unable to access the microphone~

but it does work in https://jbergknoff.github.io/guitar-tuner/ .

I think maybe you should add this code ：

navigator.getUserMedia({ "audio": true }, use_stream, function() {});

http://jonathan.bergknoff.com/journal/making-a-guitar-tuner-html5

Lower E String is recognized as higher E String

Tried this with multiple combinations of Microphones and Guitars:

The lower (2nd octave) E string, which is somewhere around 82 Hz is often recognized as the higher (4th octave) E string at > 300Hz. I guess some overtones are involved here. While tuning still works, it is much more unstable and less precise than tuning the other strings.

Impossible to find on the web

This is mostly because there is no discoverable text on the page.

Add >meta name=description< Search will display this if there is no content.
Create an entry in the Chrome web Store, this will increase the visibility.

Macos `npm i` err::: no template named 'Handle' in namespace 'v8'

npm -i out

npm WARN deprecated [email protected]: This module relies on Node.js's internals and will break at some point. Do not use it, and update to [email protected].
npm WARN deprecated [email protected]: Please use gulp-clean-css
npm WARN deprecated [email protected]: this
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: This module moved to @hapi/sntp. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated [email protected]: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated [email protected]: this package is now deprecated
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: 2.4.1 is the last version where QUnit will be published as 'qunitjs'. To receive future updates, you will need to change the package name to 'qunit'.
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: This module moved to @hapi/hawk. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.
npm WARN deprecated [email protected]: This module moved to @hapi/hawk. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: no longer maintained
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm ERR! code 1
npm ERR! path /Users/liutongtong/WebstormProjects/guitar-tuner/node_modules/node-sass
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! CXX(target) Release/obj.target/binding/src/binding.o
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | darwin | x64
npm ERR! gyp info find Python using Python version 3.8.3 found at "/opt/anaconda3/bin//python3"
npm ERR! gyp info spawn /opt/anaconda3/bin//python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/liutongtong/WebstormProjects/guitar-tuner/node_modules/node-sass/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/liutongtong/Library/Caches/node-gyp/12.20.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/Users/liutongtong/Library/Caches/node-gyp/12.20.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/Users/liutongtong/Library/Caches/node-gyp/12.20.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/Users/liutongtong/WebstormProjects/guitar-tuner/node_modules/node-sass',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! In file included from ../src/binding.cpp:1:
npm ERR! In file included from ../node_modules/nan/nan.h:111:
npm ERR! ../node_modules/nan/nan_new.h:24:36: warning: variable templates are a C++14 extension [-Wc++14-extensions]
npm ERR! template <typename T> v8::Local<T> To(v8::Handle<v8::Integer> i);
npm ERR!                                    ^
npm ERR! ../node_modules/nan/nan_new.h:24:43: error: no member named 'Handle' in namespace 'v8'
npm ERR! template <typename T> v8::Local<T> To(v8::Handle<v8::Integer> i);
npm ERR!                                       ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:24:61: error: expected '(' for function-style cast or type construction
npm ERR! template <typename T> v8::Local<T> To(v8::Handle<v8::Integer> i);
npm ERR!                                                  ~~~~~~~~~~~^
npm ERR! ../node_modules/nan/nan_new.h:24:63: error: use of undeclared identifier 'i'
npm ERR! template <typename T> v8::Local<T> To(v8::Handle<v8::Integer> i);
npm ERR!                                                               ^
npm ERR! ../node_modules/nan/nan_new.h:29:21: error: no template named 'Handle' in namespace 'v8'
npm ERR! To<v8::Integer>(v8::Handle<v8::Integer> i) { return i->ToInteger(); }
npm ERR!                 ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:34:19: error: no template named 'Handle' in namespace 'v8'
npm ERR! To<v8::Int32>(v8::Handle<v8::Integer> i)   { return i->ToInt32(); }
npm ERR!               ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:39:20: error: no template named 'Handle' in namespace 'v8'
npm ERR! To<v8::Uint32>(v8::Handle<v8::Integer> i)  { return i->ToUint32(); }
npm ERR!                ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:66:12: error: no template named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::ObjectTemplate> tmpl = v8::Handle<v8::ObjectTemplate>()
npm ERR!        ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:67:12: error: no template named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::Value> obj = v8::Handle<v8::Value>());
npm ERR!        ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:66:50: error: no member named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::ObjectTemplate> tmpl = v8::Handle<v8::ObjectTemplate>()
npm ERR!                                              ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:66:75: error: expected '(' for function-style cast or type construction
npm ERR!      , v8::Handle<v8::ObjectTemplate> tmpl = v8::Handle<v8::ObjectTemplate>()
npm ERR!                                                         ~~~~~~~~~~~~~~~~~~^
npm ERR! ../node_modules/nan/nan_new.h:66:77: error: expected expression
npm ERR!      , v8::Handle<v8::ObjectTemplate> tmpl = v8::Handle<v8::ObjectTemplate>()
npm ERR!                                                                             ^
npm ERR! ../node_modules/nan/nan_new.h:67:40: error: no member named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::Value> obj = v8::Handle<v8::Value>());
npm ERR!                                    ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:67:56: error: expected '(' for function-style cast or type construction
npm ERR!      , v8::Handle<v8::Value> obj = v8::Handle<v8::Value>());
npm ERR!                                               ~~~~~~~~~^
npm ERR! ../node_modules/nan/nan_new.h:67:58: error: expected expression
npm ERR!      , v8::Handle<v8::Value> obj = v8::Handle<v8::Value>());
npm ERR!                                                          ^
npm ERR! ../node_modules/nan/nan_new.h:85:12: error: no template named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::Value> data = v8::Handle<v8::Value>());
npm ERR!        ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:85:41: error: no member named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::Value> data = v8::Handle<v8::Value>());
npm ERR!                                     ~~~~^
npm ERR! ../node_modules/nan/nan_new.h:85:57: error: expected '(' for function-style cast or type construction
npm ERR!      , v8::Handle<v8::Value> data = v8::Handle<v8::Value>());
npm ERR!                                                ~~~~~~~~~^
npm ERR! ../node_modules/nan/nan_new.h:85:59: error: expected expression
npm ERR!      , v8::Handle<v8::Value> data = v8::Handle<v8::Value>());
npm ERR!                                                           ^
npm ERR! ../node_modules/nan/nan_new.h:93:12: error: no template named 'Handle' in namespace 'v8'
npm ERR!      , v8::Handle<v8::Value> data = v8::Handle<v8::Value>()
npm ERR!        ~~~~^
npm ERR! fatal error: too many errors emitted, stopping now [-ferror-limit=]
npm ERR! 1 warning and 20 errors generated.
npm ERR! make: *** [Release/obj.target/binding/src/binding.o] Error 1
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (events.js:314:20)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)
npm ERR! gyp ERR! System Darwin 20.2.0
npm ERR! gyp ERR! command "/usr/local/Cellar/node@12/12.20.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /Users/liutongtong/WebstormProjects/guitar-tuner/node_modules/node-sass
npm ERR! gyp ERR! node -v v12.20.0
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok

Is it my wrong operation????

Implementing to React Native

I'm trying to implement this tuner to my react native project. But there is no "getFloatTimeDomainData()" function because I don't use web audio api. Therefore, the rms value always wrong.

Is there anyone who can help me?

I think I need to use AnalyserNode in react native but how?
https://developer.mozilla.org/en-US/docs/Web/API/AnalyserNode

getting 500 Internal server error

Hey!
Has anything changed in the library?
I followed the directions,
started the google app engine, browse to localhost:8080, getting 500
Any way to see logs of the app?

Thanks

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.