Giter VIP home page Giter VIP logo

marked-element's Issues

Snippet of code is being executed

Hello. As I was doing a demo for a presentation, getting issues from github and taking their body and using the marked-element to print the markdown.

Unexpectedly, it executed the code and changed my app in Chrome (altough in Firefox it did not).

The example I used is actually from a polymer issue from the github api, so this code should show the error:

<html>
  <head>
    <base href="http://polygit.org/polymer+:master/components/">
    <link href="polymer/polymer.html" rel="import">
    <link href="marked-element/marked-element.html" rel="import">
    <link href="iron-ajax/iron-ajax.html" rel="import">
  </head>

  <body unresolved>
    <template is="dom-bind" id="app">
      <iron-ajax url="https://api.github.com/repos/Polymer/polymer/issues/2481" last-response="{{issue}}" auto></iron-ajax>
      <marked-element markdown="{{issue.body}}">
        <div class="markdown-html"></div>
      </marked-element>
    </template>
  </body>
</html>

Why install marked as a sibling directory of this element?

In installing marked I noticed that the marked dependency is installed as a sibling of this element (they are both installed under bower_components). Is there a reason for this?

I think that marked should live inside marked-element to make dependency management and possible vulcanization better.

Thoughts?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.