Giter VIP home page Giter VIP logo

golox's Introduction

Anurag's github stats

Keyboard

Readme Card Readme Card Readme Card Readme Card Readme Card

Build Your Own X From Scratch

Readme Card Readme Card Readme Card Readme Card Readme Card Readme Card

golox's People

Contributors

goropikari avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

golox's Issues

Golox fails to assign variable from method

When running a script like:

// This benchmark stresses method invocation by batches

class Toggle {
    init(startState) {
        this.state = startState;
    }

    value() { return this.state; }

    activate() {
        this.state = !this.state;
        return this;
    }
}

var start = clock();
var val = true;
var toggle = Toggle(val);
var batch = 0;

while (clock() - start < 10) {
    for (var i = 0; i < 10000; i = i + 1) {
        val = toggle.activate().value();
    }

    batch = batch + 1;
}

Golox encounters a golang runtime error and panics with: panic: runtime error: hash of unhashable type ast.Call.

The ast.Call expression contains a slice of arguments. Golang does not allow the hashing of objects that contain slices and this is what I believe to be the cause of the bug.

The required hashing exists in VisitAssignExpr. The hash key is currently the interface type Expression so that different kinds of expressions can be hashed locally. Currently all of the expression nodes are passed by value so a possible solution could be to start passing nodes by reference instead of value. Alternatively, we could assign a new function to each node that provides a string for Golang to consistently hash.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.