gostaticanalysis / comment Goto Github PK

Due to a logic error in hasIgnoreCheck, the "lint:ignore" directive is not actually checked -- comments such as //foo:bar [Check] reason will still "match" (be ignored) as long as the check matches the provided check.

See this issue: golang/go#37974

A short investigation shows that the method in question relies on output of func (g *CommentGroup) Text(), which was affected by this change.
Since //lint:ignore is now considered a directive-like comment, this stopped working. An original info is still present and may be extracted in another manner.

This method is used in several analysis tools, and it seems to work in a bizarre fashion.
It takes the entire fileset (as I understand it, typically all files in a package) and then looks up comment by file line.
I just had a debugging session where I found out that, unsurprisingly, this method can sometimes return comment from another file within a package.

So it is possible that all those usages are currently broken.