@google-cloud/[email protected] › @google-cloud/[email protected] › [email protected] › [email protected] › [email protected] > ...

Snyk vuln report

Would be nice to run this project locally. I am attempting to use the datastore emulator to do this with the functions framework and will report back.

I am also trying to use the functions-framework.

I was looking at the docs here https://cloud.google.com/datastore/docs/quickstart

They recommend Cloud firestore for new projects, would that work with this tutorial, do they have the same api?

see also https://cloud.google.com/firestore/docs/firestore-or-datastore?_ga=2.192589097.-228521414.1555746435

I have the following data for articles:

When running this query:
const tags = (await ds.createQuery(namespace, 'Article').select('tagList').run())[0];

Will return

I feel that we should not return this null item. Or the client should handle it.

what do you think?

In the original app tags are limited by number and popularity, but in this implementation, any and all tags are displayed:

I will probably add this to my fork

We now have https://github.com/GoogleCloudPlatform/functions-framework-nodejs

You specify to

Create a service account and store the credentials as service-account-key.json in the repo root folder - DO NOT SHARE THIS FILE!

However, could we not just use the default service account for this tutorial?

Hello,

i have this error when try to run npm test

npm ERR! Failed at the @ test:unit script 'DATASTORE_NAMESPACE=test-unit-date +%s nyc mocha --opts .mochaopts ./src/.test.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! DATASTORE_NAMESPACE=test-unit-date +%s nyc mocha --opts .mochaopts ./src/.test.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls
npm ERR! There is likely additional logging output above.

my node version is v6.11.5

we can help me to resolve ?

thanks

I now have locally emulation of everything set up and could add a PR for this. However, I am not sure what the plan is for this repo going ahead. Will, it still be maintained or will I maintain my own fork/clone of it.

you can see the local emulation in here:

https://www.youtube.com/watch?v=7LqkLTGR54E

https://cloud.google.com/functions/docs/concepts/nodejs-8-runtime

My fork is starting to diverge in some fixes, and I'm not inclined to raise any more PRs as its getting more difficult to backport PRs and I haven't had comments on my PRs. Can you advise how the community can best help your excellent work in this project?

I tried to run npm test, but the npm i didn't work:

see
kelektiv/node.bcrypt.js#728

My console:

 gcp-datastore-cloud-functions-realworld-example-app git:(master) nd

> @ deploy /Users/nikos/WebstormProjects/gcp-datastore-cloud-functions-realworld-example-app
> ./deploy-to-cloud.sh

GCLOUD_BIN=gcloud
Deploying function...
You do not currently have this command group installed.  Using it 
requires the installation of components: [beta]


Your current Cloud SDK version is: 247.0.0
Installing components from version: 247.0.0

┌─────────────────────────────────────────────┐
│     These components will be installed.     │
├──────────────────────┬────────────┬─────────┤
│         Name         │  Version   │   Size  │
├──────────────────────┼────────────┼─────────┤
│ gcloud Beta Commands │ 2019.05.17 │ < 1 MiB │
└──────────────────────┴────────────┴─────────┘

For the latest full release notes, please visit:
  https://cloud.google.com/sdk/release_notes

Do you want to continue (Y/n)?          ^[[2B^[[2B

also see GoogleCloudPlatform/cloud-sdk-docker#74

Hi,

I am trying to add CORS to this app and could really find the best way of having Access-Control-Allow-Origin as I am running the frontend on localhost:4200. All of my requests are being blocked in GCP.
I am trying to figure out where should I add the CORS. (Sorry, I am quite new to Nodejs and this may seem a silly question)

I was reading this
https://github.com/expressjs/cors
and then this
https://github.com/gothinkster/realworld/tree/master/api

which says I need to use OPTIONS to return correct headers.
I have this in my code in the Router.js

const headers = {}; headers["Access-Control-Allow-Origin"] = "*"; headers["Access-Control-Allow-Methods"] = "POST, GET, PUT, DELETE, OPTIONS"; headers["Access-Control-Max-Age"] = '86400'; // 24 hours headers["Access-Control-Allow-Headers"] = "Authorization, X-Requested-With, X-HTTP-Method-Override, Content-Type, Accept";

and also having a check

if (req.method === 'OPTIONS') { res.writeHead(200, headers); res.send(); }

But my app still throws the error

Failed to load https://my-app/api/tags: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4200' is therefore not allowed access.

Any help would really be appreciated.

Thanks!

This code here should be allowed to pass if the user has not modified his email:

https://github.com/gothinkster/gcp-datastore-cloud-functions-realworld-example-app/blob/master/src/User.js#L48

Moved this issue from here sveltejs/realworld#34 as https://demo.realworld.io handles the case where the email is the same allowing the user to save with the same email address.

If we know the user doesn't exist, why not use an insert to be more clear?

I opened a room in my Google Cloud server for anyone else using this project and wants to discuss.

https://discord.gg/f44DZQC

I also am working on a fork to get local debugging to work:
https://github.com/QuantumInformation/gcp-datastore-cloud-functions-realworld-example-app

The current CLI for setting indexes is gcloud datastore indexes create index.yaml. Should be a quick fix in the README.