gpodder / detlef Goto Github PK

Logo downloads are currently displayed as a notification by the download manager. Disable this behavior.

Reproduction: Add some Podcasts, go to "Show all Episodes" and sort by release date. Then click on the search icon in the bottom right corner. The search widget opens and the list is sorted by podcast.
Expected Behaviour: The order should stay the same as it was before opening the search.

There are some design guidelines for Android which you should make use of:
https://developer.android.com/design/index.html

Especially

• https://developer.android.com/design/patterns/app-structure.html / Section "Allow cutting through hierarchies"
• Action Bar - https://developer.android.com/design/patterns/actionbar.html
• Selection - https://developer.android.com/design/patterns/selection.html

Instead of the player tab I would add the playlist there. The player could be always visible at the bottom instead of the Refresh/Playlist/Search/Sort buttons

If you make use of the Action Bar you can move the refresh and search action into the Action Bar.

If you make use of the selection feature you can select more than one episode and start an action for all of them (download, mark as listened, move to the playlist)

Here is an inspiring video where a developer explains design/layout changes in his app. The new app looks really amazing:
https://www.youtube.com/watch?v=hpqUbpVx5Bo

I would like to have a way to delete the episodes I have listened. I now end up deleting them from the file system.

There might be a more elegant way, but if so, I did not find it yet.

I've installed detlef from the play store. Every time I hit the refresh button, I get the "refresh successful" message but no podcasts are shown. In practise I cannot get the podcasts (and the episodes) from my gpodder.net account (the account verification was ok and I can see my phone in the device list). I'd love to make a wireshark capture to see what's going on but I don't think it's so easy to get one on android.

At the moment I couldn't find the date/time information for an episode. This information should be in the episode list and in the player activity above or under the shownotes.

All other players or podcast clients I used before pause the playback when you unplug your headphones.
You can test this with:

• Antennapod - https://play.google.com/store/apps/details?id=de.danoeh.antennapod
• Apollo - the music player included in cyanogenmod
• Winamp - https://play.google.com/store/apps/details?id=com.nullsoft.winamp
• Google Music Player - https://play.google.com/store/apps/details?id=com.google.android.music

If you unsubscribe to a feed on gpodder.net, and you refresh in detlef, the feed still shows up in the feed list. It's icon is gone, but the episodes still show up.

The podcast is deleted from the database, and it is gone when Detlef is restarted. So I think it is some caching problem. Probably the cache should be invalidated or something.

Today I listened to an episode and without pausing the playback I called a number from my phone book.
But the episode is still playing while the telephone is ringing. You should pause the playback until I hang up the phone call

Today, detlef crashed during a refresh operation.

I used alogcat to find the problematic feed: http://smlr.us/?feed=rss2&cat=4

This is the sunday morning linux review. Normally on smlr.us, but the domain isn't being resolved.

Of course it is not Detlef's problem that the feed isn't available, but refresh should not crash because of this :-)

Change the text "your device is now connected to gpodder.net. Detlef will now synchronize your podcast list." to something that says that the user should add the device to a synchgroup before synchronizing with the podcast list.

Using gpodder.net for feed parsing is slow. Instead, fetch and parse feeds locally.

Some podcast logo files seem to vanish after the initial download.

02-12 16:24:08.078: V/at.ac.tuwien.detlef.download.DetlefDownloadManager(12162): File /mnt/sdcard/Android/data/at.ac.tuwien.detlef/files/Pictures/Science_Friday_Audio_Podcast/Podcast600-1.png downloaded successfully
02-12 16:32:42.574: W/at.ac.tuwien.detlef.domain.Podcast(12162): Removing reference to invalid logo path /mnt/sdcard/Android/data/at.ac.tuwien.detlef/files/Pictures/Science_Friday_Audio_Podcast/Podcast600-1.png

The download appears to be successful, but opening the image fails.
To reproduce:

1. clear detlef data
2. add several podcasts (the entire toplist + suggestions)
3. wait until refresh is done
4. scroll down the list

Several images are already lost in this pass.

5. close & reopen detlef
6. scroll down the list

More images are lost now.

It should be possible to view the episode's full information without starting it playing. There should be another click to actually play it. Clicking this should probably promote it to the top of the playlist.

Please show the complete show notes and also show the provided links so that I can start the browser directly from the player activity

In this case, it was done via toplists/suggestions.

When the episode description is short (so that no "..." is needed in the episodes view), there is a display bug (see screenshot below, first episode, at the end of the description)

My handset is on Android v2.1, with no prospect of it being upgraded by the manufacturer.

Is there any chance of this app being upgraded to work with this version of android?

Sorting episodes on release date does not work in the working branch.

Since recently, the notification does not respond to most clicks on my SGS1.

If you start a download when the SD card is full, detlef keeps trying to download, consuming lots of power and lots of bandwidth.

Show the short license name in small list elements.

Refresh takes quite some time when the user is subscribed to more podcasts, maybe change to device updates API endpoint

Adapt the set up process such that the user gets a list of devices in the set up screen along with an option "Register new device".

The use case is that a user might want to import an existing device id if a new device is bought.

Suggested at the gpodder.net hackday

On other podcast or media players there is the "Sleep timer" feature.
You can define a time in Hour:Minutes when the application should stop to play an episode. This is really nice if someone likes listen to podcasts while going to bed.

Detlef currently sends a "new" episode action for every new episode it detects. As actions are shared among devices and are meant to semantically "overwrite" each other, this does not reflect the intended meaning. A "new" action should be used to mark an episode as new again, eg after it has been played. As there is (currently) no such functionality in detlef, it should not send such actions at all.

Make sure it's using foreground mode, like bherrmann7/Car-Cast#38, Documentation here.

I did a quick grep of the code for startForeground or setForeground and didn't find anything.

This occurred while refreshing 39 podcasts (including duplicates!). There was initially a huge slowdown, the screen was locked once or twice, and the screen was rotated one or two times.

E/AndroidRuntime( 1427): FATAL EXCEPTION: pool-1-thread-1
E/AndroidRuntime( 1427): java.lang.NullPointerException
E/AndroidRuntime( 1427):        at at.ac.tuwien.detlef.db.CachingEpisodeDAO.getEpisodeByUrlOrGuid(CachingEpisodeDAO.java:106)
E/AndroidRuntime( 1427):        at at.ac.tuwien.detlef.gpodder.SyncEpisodeActionsAsyncTask.applyActionChanges(SyncEpisodeActionsAsyncTask.java:135)
E/AndroidRuntime( 1427):        at at.ac.tuwien.detlef.gpodder.SyncEpisodeActionsAsyncTask.run(SyncEpisodeActionsAsyncTask.java:94)
E/AndroidRuntime( 1427):        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
E/AndroidRuntime( 1427):        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
E/AndroidRuntime( 1427):        at java.lang.Thread.run(Thread.java:856)

As Detlef is a standalone project now and is no longer developed within the scope of a university course, rename the packages from at.ac.tuwien.detlef to net.gpodder.detlef.

On my Nexus-S (Cyanogenmod 10.1) the startup time is about 15-25sec.
This is definitely too long!

Setting where user can choose with which devices to synchronize his own device.

I can't figure out how the podcast list is sorted. So please sort them alphabetically. Maybe you could add an option for different sorting, but there should be a sort criteria by default

This bug causes strange behaviour, like e.g. Detlef deleting all episodes from the database when you delete one podcast feed.

Today I listend to an episode and the playback of detlef stopped.

• the first time I started a download over my wifi
• the second time I started Airdroid and the playback stopped the moment I logged into my phone from my desktop
• the third time after I started aLogCat. Sadly there is no usable log output

When I start the playback again it starts about 10-15min before it stops. I think the last position I pressed pause by myself.

With this behaviour Detlef is really useless because I have to find the right position in the episode every time Detlef stops the episode

if a podcast icon has special characters in it's name it will not be copied to internal storage after download

When first starting Detlef it asks for a username and password. It is, however, not obvious if a user is about to create a new account somewhere, or if he should use existing credentials, and even which site those refer to.

I'd recommend to explicitly ask for a "gpodder.net username" and offer a link to the registration page (https://gpodder.net/register)

when I listen to an episode the mini-player in the notifcation area shows up and is usable. But if I close Detlef (e.g. via swiping it in the recent tasks screen) the player is still there but is unusable (can be closed extra via clicking on the X, but then also shows up again on the next start of Detlef)

This is probably not the most urgent issue, but I add it for the sake of completeness :-)

Detlef used to have unit tests, but in the working branch they are deleted in 30E360. It would be cool if we could reintroduce unit test projects, because they can prevent us from making the same mistakes over and over again.

Unlike changing the user name, changing the password & device name does not trigger account reverification.

I have this issue on the working branch, on master it works as expected.

If you add a new subscription using the gpodder.net website or another (synchronised) client, Detlef doesn't pull the new subscription when refreshing. The same problem when a subscription is deleted.

The app actually became unresponsive during this period.

In the log, many lines such as this one appear:

D/dalvikvm( 1427): GC_CONCURRENT freed 3072K, 52% free 11365K/23495K, paused 1ms+4ms

E/ActivityManager(  196): ANR in at.ac.tuwien.detlef (at.ac.tuwien.detlef/.activities.MainActivity)
E/ActivityManager(  196): Reason: keyDispatchingTimedOut
E/ActivityManager(  196): Load: 1.32 / 1.02 / 0.61
E/ActivityManager(  196): CPU usage from 8617ms to 3556ms ago:
E/ActivityManager(  196):   81% 1427/at.ac.tuwien.detlef: 59% user + 22% kernel / faults: 552 minor
E/ActivityManager(  196):   7.9% 196/system_server: 6.9% user + 0.9% kernel / faults: 288 minor
E/ActivityManager(  196):   2.1% 134/surfaceflinger: 0.9% user + 1.1% kernel / faults: 670 minor
E/ActivityManager(  196):   1.9% 108/yaffs-bg-1: 0% user + 1.9% kernel
E/ActivityManager(  196):   0% 137/mediaserver: 0% user + 0% kernel / faults: 5 minor
E/ActivityManager(  196):   0.9% 12/kworker/0:1: 0% user + 0.9% kernel
E/ActivityManager(  196):   0.9% 269/com.android.systemui: 0.7% user + 0.1% kernel / faults: 699 minor
E/ActivityManager(  196):   0.9% 1058/kworker/u:3: 0% user + 0.9% kernel
E/ActivityManager(  196):   0.5% 331/com.google.process.gapps: 0.1% user + 0.3% kernel / faults: 215 minor
E/ActivityManager(  196):   0% 5/kworker/u:0: 0% user + 0% kernel
E/ActivityManager(  196):   0% 384/com.android.phone: 0% user + 0% kernel / faults: 15 minor
E/ActivityManager(  196):   0.1% 424/android.process.acore: 0.1% user + 0% kernel / faults: 259 minor
E/ActivityManager(  196):   0% 957/com.android.calendar: 0% user + 0% kernel / faults: 14 minor
E/ActivityManager(  196):   0% 1217/com.android.mms: 0% user + 0% kernel / faults: 150 minor
E/ActivityManager(  196): 99% TOTAL: 70% user + 29% kernel
E/ActivityManager(  196): CPU usage from 501ms to 1019ms later:
E/ActivityManager(  196):   90% 1427/at.ac.tuwien.detlef: 90% user + 0% kernel / faults: 92 minor
E/ActivityManager(  196):     78% 1427/c.tuwien.detlef: 78% user + 0% kernel
E/ActivityManager(  196):     9.6% 1429/GC: 9.6% user + 0% kernel
E/ActivityManager(  196):     1.9% 1501/pool-1-thread-1: 1.9% user + 0% kernel
E/ActivityManager(  196):   1.2% 12/kworker/0:1: 0% user + 1.2% kernel
E/ActivityManager(  196):   1.2% 108/yaffs-bg-1: 0% user + 1.2% kernel
E/ActivityManager(  196):   1.9% 196/system_server: 0% user + 1.9% kernel / faults: 1 minor
E/ActivityManager(  196):     1.9% 232/InputDispatcher: 0% user + 1.9% kernel
E/ActivityManager(  196): 98% TOTAL: 92% user + 3.7% kernel + 1.8% softirq

All other media players or podcast clients I used before adding a widget to the lock screen, so you can pause/play your playback directly from your lock screen.
Without this widget you have to unlock your phone and activate your notification area to pause a playback which takes a lot more time.

Hello detlef team,

I noticed that the following feed does not appear in the gpodderson application when synchronizing from gpodder.net

http://gdata.youtube.com/feeds/base/users/StanfordUniversity/uploads?alt=rss&v=2&orderby=published&client=ytapi-youtube-profile

I have subscribed to the feed from the website, and installed and configured the app on both my phone (Samsung S3 mini) and my tablet (Samsung note 10.1) and no matter how many times I add and remove the feed, it does not appear in the list of podcasts. It does sync on gpodder desktop, though, but it had an empty description or sth similar.

Thanks for your work!
Thomas

I've added several feeds (some via detlef, some via gpodder.net assignment; some of those that I already listen to on other devices, others that are new to me). Every podcast appears to add fine, and appears with album artwork, however attempting to refresh so as to get episode listings results in a "HTTP/1.1 500 INTERNAL SERVER ERROR" popup message and no episodes ever appear for any of the subscriptions.

This is on a Nexus 4 running Android 4.2.2, build JDQ39 (entirely stock; not even rooted). I've tested this on my cellular connection and via wifi; on both networks my Nokia N9 is able to fetch episode listings. On the other hands, wouldn't entirely rule out network issues on my end or somewhere along the line.

I can try with my Nexus 7 later today, likely, but I figured I'd post now in case it's a known issue (I looked here, but I may just be blind) or otherwise easily fixable and/or explicable.

Android's terminology is talking about preferences and not about settings. So every class and variable that referes to the android preferences and has a prefix "Settings" should be renamed into "Preferences" for consistency's sake.

e.g. public class SettingsGpodderNet extends PreferenceFragment

should become

public class PreferencesGpodderNet extends PreferenceFragment

It's not that urgent, but shouldn't be that much effort either.

On the current git version, the podcast logo does not show up reliably when first adding a podcast. The logo is downloaded, but the displayed icon is retrieved before that's done and is never updated subsequently.
After a restart, the logo appears.