gprimola / jenkiexs Goto Github PK

I noticed something in Jenkiexs.Buids.details/2 but didn't want to change in the abovementioned PR because it's not its purpose.

Jenkiexs.Builds.details/2 uses Client.get!/3 as follows:

  def details(job_name, build_number) do
    case Client.get!("/job/#{job_name}/#{build_number}/api/json") do
      %{status_code: 200, body: body} ->
        build = new(job_name, body)
        {:ok, build}

      %{status_code: status, body: body} ->
        {:error, "Got status #{status} with body #{inspect(body)}."}
    end
  end

What do you think about changing that request to Client.get/3 and then creating a Jenkiexs.Builds.details!/2 just to keep the API consistent?

Originally posted by @dflima in #18 (comment)

Please, follow this guidelines

Please, follow this guidelines

The lib is in version 0.9 only due to lack of unit tests.

After fixing #21, there's a compilation error in test/support/mock_server/jenkins.ex

== Compilation error in file test/support/mock_server/jenkins.ex ==
** (SyntaxError) test/support/mock_server/jenkins.ex:8: syntax error before: '->'
    (elixir) lib/kernel/parallel_compiler.ex:229: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/7

The code is as follows:

  get "/api/json" do
    cond do
      is_nil(conn.params["tree"]) ->

      String.match?(conn.params["tree"], ~r/\Ajobs/) ->
        "jobs[name,description,fullName,displayName,fullDisplayName,inQueue,buildable,disabled,nextBuildNumber,property[parameterDefinitions[name,defaultParameterValue[value]]]]"
    end
  end

There's no code block after is_nil(conn.params["tree"]) ->

Please, follow this guidelines

Please, follow this guidelines

Please, if you may, follow this recommendations!
Thank you!!

The mock server is Jenkiexs.MockServer.Jenkins.
The idea is to mock calls to a real jenkins server.

Feel free to propose a different approach 👍

There are some modules on test/support that are not being compiled when running mix test.

➜  jenkiexs git:(master) ✗ mix test
Compiling 7 files (.ex)
Generated jenkiexs app
** (UndefinedFunctionError) function Jenkiexs.MockServer.start/0 is undefined (module Jenkiexs.MockServer is not available)
    Jenkiexs.MockServer.start()
    test/test_helper.exs:1: (file)
    (elixir) lib/code.ex:813: Code.require_file/2

We should add the elixirc_paths attribute on the Jenkiexs.MixProject.project/0 function.