Comments (4)
Also doesn't seem to work on RTX 20 series.
from fidelityfx-fsr.
I have a similar problem with RTX3060Ti and FP16 setting. And in my case, it's because that FsrRcasH computes a wrong rcpL with APrxMedRcpH1 (line 863, ffx_fsr1.h). Simply replace this with AF1 rcpL=APrxMedRcpF1(AF1_(4.0)*lobe+AF1_(1.0)); can make it work. It seems APrxMedRcpH1 has some problems with it.
from fidelityfx-fsr.
GTX 1660Ti using FP16 (A_HALF) have similar issue on DX11, outputs black from RCAS. Works fine on DX12.
Fallback to FP32 works for both DX11 and DX12.
Seems related to FsrRcasH as @UUNagato stated. Changing to the suggested line does indeed output something, however not the expected result (for me at least).
According to FidelityFX-FSR-Overview-Integration (slide 27-28) special care have to be taken when choosing between FP32 and FP16, even when FP16 is supported.
Makes me question using FP16 at all.
from fidelityfx-fsr.
Not sure if it's the reason but I guess a possible explanation for this bug is that APrxMedRcpH1 assumes we are using 16bit float and integer type. However, writing shader with types like "min16uint" or "min16float" doesn't guarantee the graphics card will run them in 16bits. It's often 32bits and thus APrxMedRcpH1 fails since it assumes the float number is 16bits. (0x778d is a constant for 16bit float layout).
AH1 APrxMedRcpH1(AH1 a) { AH1 b = AH1_AW1(AW1_(0x778d) - AW1_AH1(a)); return b * (-b * a + AH1_(2.0)); }
Replace it with APrxMedRcpF1 will work because the graphics card can always run 32bit float when you write float or float32_t.
from fidelityfx-fsr.
Related Issues (20)
- Wasm support HOT 2
- Noise free feature HOT 3
- FidelityFX-FSR
- Noise related HOT 1
- Quality issue on FSR input to target Res table HOT 1
- Track atyuwen mobile trade-off optimization
- Denorm handling on nvidia GPUs
- Question to FSR Team at AMD HOT 1
- fps when use fp16 is not faster than FP32 On RTX2070 with Max-Q card HOT 1
- support for nvidia gtx 900 series? HOT 1
- typo in NEG MIP BIAS commit 1.0.2 between sample code and DOCs
- [iGPU as FSR Renderer] AMD Advantage Program Laptops HOT 1
- FSR code doesn't compile for HLSL 2021 HOT 1
- Pls help me for fsr example HOT 1
- Possible forgotten use of FSR_RCAS_DENOISE? HOT 2
- AMD should reuse/adapt the academic State Of The Arts HOT 9
- question about luma*2
- fsr 1.0 ue4.27 on mac m1
- UE plugin release history
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fidelityfx-fsr.