gradiant / dockerized-hadoop Goto Github PK

Looks nice but I suggest remove unsupported architectures, unless you really have access to those:

• arm32v7
• arm64v8
• i386
• ppc64le
• s390x

I suggest sticking to the:

• amd64
• (maybe) arm32v7 (but those usually got not enough memory on the device)
• (maybe) arm64v8.

Otherwise it will be just maintenance burden that no one uses - aka dead code.

.env should be rather .env.dist to avoid issues with other git clones.

Maybe it would be better to switch from bash scripts to Makefile?

Hi god:
Can you provide a chart and mirror of AARCH64 about hbase. thanks a lot.

Current docker images are based on java jre apline - which contains jre 1.8u171 ... dates around 2018.07.17

It requires to pass additional java opts to processes via env var like JAVA_OPTS such as:

-XX:+UnlockExperimentalVMOptions \
-XX:+UseCGroupMemoryLimitForHeap \
-XX:MaxRAMFraction=2

Fix:
Update base image to java jre alpine (highest is with 1.8u212 https://hub.docker.com/_/openjdk?tab=tags&page=1&name=8u212-jre-alpine ) which has backported fixes for detecting containerized apps ( see https://www.oracle.com/technetwork/java/javase/8u191-relnotes-5032181.html)
and looks like it just needs bumping in corresponding Dockerfiles here and related projects using this images.

This will help in running the stack in docker/k8s without the need of passing fine grained paramters to adjust java options to avoid OOM kills.

docker pull openjdk:8-jre-alpine
8-jre-alpine: Pulling from library/openjdk
e7c96db7181b: Pull complete 
f910a506b6cb: Pull complete 
b6abafe80f63: Pull complete 
Digest: sha256:f362b165b870ef129cbe730f29065ff37399c0aa8bcab3e44b51c302938c9193
Status: Downloaded newer image for openjdk:8-jre-alpine
docker.io/library/openjdk:8-jre-alpine


docker run -it openjdk:8-jre-alpine /usr/bin/java -version
openjdk version "1.8.0_212"
OpenJDK Runtime Environment (IcedTea 3.12.0) (Alpine 8.212.04-r0)
OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)