Giter VIP home page Giter VIP logo

Comments (6)

simonswine avatar simonswine commented on May 27, 2024 2

I think we should also make sure that we make it pretty clear what the X-axis represents.

Because for histograms panel it will be time and for the flamegraph it is amount of resource used.

from phlare.

simonswine avatar simonswine commented on May 27, 2024

@joey-grafana has already tried the PR with the metrics API and was able to convert it into a data frame that gets rendered as a graph.

from phlare.

bboreham avatar bboreham commented on May 27, 2024

I'd like to request that the values should match up to data from other sources; e.g. "memory" for a Go program should match up to "go heap size" from Prometheus. (This might seem obvious, but it's not the case with Pyroscope).

from phlare.

joey-grafana avatar joey-grafana commented on May 27, 2024

@cyriltovena @simonswine None of the current profiles return multiple series for the time series graph. It would be great to see multiple series lines in the time series graph for testing.

Also, what can we label each of the series (lines) in the graph legend on the bottom of the graph?

Might relate to either of the following two;

  • Select via dropdown labels name to group by (see the #160): I think this is what we're doing already when selecting profiles? Or that you'd like another dropdown to select labels..
  • Add a new label selector based on a selected series in the query: I'd imagine if we select a particular series (which has a label), we can add that label in between the '{}' in the input field next to the profile label selector dropdown?

Screenshot 2022-08-30 at 14 45 53

from phlare.

cyriltovena avatar cyriltovena commented on May 27, 2024

You need to pass the group by parameter to see multiple series. Otherwise it group them all into one series.

Select via dropdown labels name to group by (see the #160)

I'd like that we add a dropdown to select labels to group by, I was thinking inside the graph panel, but anywhere would do at first. This might requires a new LabelNames API ?

https://prometheus.io/docs/prometheus/latest/querying/api/#getting-label-names

from phlare.

cyriltovena avatar cyriltovena commented on May 27, 2024

I'd like to request that the values should match up to data from other sources; e.g. "memory" for a Go program should match up to "go heap size" from Prometheus. (This might seem obvious, but it's not the case with Pyroscope).

Can you expand on this request @bboreham

from phlare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.