Giter VIP home page Giter VIP logo

Comments (9)

core-code avatar core-code commented on July 21, 2024

...new key @"2"

from lockbox.

granoff avatar granoff commented on July 21, 2024

Thanks for reporting this. Unfortunately, I cannot reproduce this, and my unit tests (newly added to this project) confirm that the class is working as expected.

It'd be interesting if you wouldn't mind grabbing the latest code from my master branch and running the unit tests on your machine. (Open the LockBox project and go to Product -> Test). Do they all pass?

from lockbox.

core-code avatar core-code commented on July 21, 2024

did you test on Mac OS X? i couldn't even get it to compile on Mac OS X without some changes...

yes i had the latest code, obtaining old code isn't even easy with github ;)

from lockbox.

granoff avatar granoff commented on July 21, 2024

The tests (which I just pushed to this repo) run on Mac OS X.

from lockbox.

core-code avatar core-code commented on July 21, 2024

thanks i'll have a look tomorrow.

from lockbox.

core-code avatar core-code commented on July 21, 2024

i couldn't find a way to run the tests on Mac OS X directly from the provided xcode project as it is iOS only and chaning it didn't really work. additionally the main Lockbox.m still didn't compile on Mac OS X without minor changes.

i've creates a new project "test", imported Lockbox master and still get the same behaviour.

https://dl.dropbox.com/u/7221986/lockbox.zip

just run test/test.xcodeproj and see it hanging in the assertion

from lockbox.

granoff avatar granoff commented on July 21, 2024

Hmm. Ok, it doesn't work under Cocoa, just Cocoa Touch.

I ran your code and stepped through it and saw the same issues you saw. The project provided with this repo is an iOS project. I think the issue is that the keychain under Mac OS works slightly differently than under iOS, which is unfortunate to be sure.

I don't have the time right now to figure this out for Cocoa; sorry. The issue has something to do with the dictionary provided to SecItemDelete() because it is returning a status indicating it cannot find the key in question to remove, before we set the new value. But I would be happy to accept a pull request that makes the class work for both Cocoa and Cocoa Touch. :-)

from lockbox.

core-code avatar core-code commented on July 21, 2024

no problem. i've switched to another keychain wrapper which works fine out-of-box, just wanted to let you know about the issues.

from lockbox.

granoff avatar granoff commented on July 21, 2024

I appreciate it; thanks. Truth be told, I am an iOS developer and I developed the class for an iOS project. I don't do Mac OS work, but I suppose I might someday. So I'll leave this issue open as a reminder that there's an issue for Cocoa use.

from lockbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.