Giter VIP home page Giter VIP logo

Comments (7)

hannseman avatar hannseman commented on July 2, 2024 1

Enabling Keychain sharing appears to fix this issue for some reason.

from lockbox.

granoff avatar granoff commented on July 2, 2024

Thanks @hannseman !

@alexeybolv : What version of iOS was on your device at the time?

I think it is unfortunate that Keychain Sharing must be enabled just to store something in your own keychain especially if you have no intention of sharing your keychain. I think a little more investigation is required, perhaps.

from lockbox.

alexeybolv avatar alexeybolv commented on July 2, 2024

iOS version is 10.0

from lockbox.

granoff avatar granoff commented on July 2, 2024

@alexeybolv: I figured as much.

Well, enabling Keychain Sharing seems to be the quick fix, at least. It may be the fix, which seems like an awfully big hammer to me, at the moment.

We'll leave this issue open for the time being as a reminder.

from lockbox.

granoff avatar granoff commented on July 2, 2024

When you enable Keychain Sharing, as I did in the Lockbox project, Xcode adds a keychain group. I tried removing that group from the list of enabled groups while keeping Keychain Sharing enabled. The unit tests passed.

It would be nice if there was a way to have the entitlements set properly when the Lockbox cocoapod is installed, but I don't think there's a way to do that. Documentation will have to suffice, I think.

from lockbox.

granoff avatar granoff commented on July 2, 2024

I've pushed the changes I made earlier which include:

  • Enabled Keychain Sharing in the sample project, but removed the keychain group that Xcode added to the list of keychain groups. It's not needed (especially because we're not sharing, by default), but the entitlement is apparently needed to access the keychain, whether you're sharing it or not.
  • Updated the README
  • Bumped the version to 3.0.2

There are no functional changes to Lockbox itself.

from lockbox.

iwasrobbed avatar iwasrobbed commented on July 2, 2024

Seems like a radar should be filed for this; no reason to share the keychain if you only have one app accessing it. Either that or there is an iOS 10 bug in this library that is inherently forcing this to be triggered since I've seen others not have to use this as an option.

from lockbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.