memory leak about lockbox HOT 4 CLOSED

Thanks for the heads up. I think Lockbox handles the release of data under non-ARC compilation with this block of code at the end of -objectForKey::

#if !__has_feature(objc_arc)
    [s autorelease];
    CFRelease(data);
#endif

from lockbox.

I'm claiming that it needs to be:

#if !__has_feature(objc_arc)
    [s autorelease];
#endif
CFRelease(data);

...because ARC doesn't recognize the need to release data.

from lockbox.

Oh ,I see what you're saying. Nope, not needed because for ARC, the memory is __bridge_transfer'd:

    NSString *s = [[NSString alloc]
                    initWithData:
#if __has_feature(objc_arc)
                   (__bridge_transfer NSData *)data
#else
                   (NSData *)data
#endif
                    encoding: NSUTF8StringEncoding];

which passes ownership of data to ARC. So no CFRelease under ARC for data is required. (At least if I understand the __bridge_transfer semantics correctly.)

from lockbox.

Got it. Thanks.

from lockbox.