gravity-ui / components Goto Github PK

It turns out that the user needs to guess that there are actions here, click (to get the state as in the screenshot, this is a type of hover effect) and only after that he will be able to click on the action he is looking for

As ShareListItem use external links only, so one should set rel="external" on share links

Like this https://www.npmjs.com/package/react-compare-slider

I think it's worth making it in a composite approach so that its functionality can be easily expanded by users

There are a lot of complex features that can be taken out as separate components or libraries, I just wrote everything I would like to see

1. Add several sizes, I also want to use them in a system that simulates file storage on the web. In particular, you want to have a super small size or maybe a direction property to place it in the table
2. Add folders
3. I want to have two modes - dynamic and static.
   In the first one, as you have, a file is accepted and your component automatically determines which icon to display, which data, etc. This is not the case now. At the same time, it is desirable that the developer has the opportunity to give either a link or the file itself.
   In the second one, I do not want to write as any, I want to specify the characteristics of the file in order to display them, for example, taken from the database initially, why I should implement the web api File interface is not entirely clear.
   Now you have implemented something in between
4. It is also worth considering the 'selected' state, if we are emulating a file system, we want to have this feature
5. It would also be very nice to see adapters, or write your own solutions to implement quick viewing of photos, videos at least, the rest as needed

1). We want to change default behaviour, to render tab titles without any ellipsis.

Now it works like this:

We want to change it to display tab title completely. And if some tab does not fit into container — move it to select.

2). We want to add a property for this component, that will configure how many tabs will be rendered without moving them to select.

Please add an editable property or the ability to add your own controls:

We use this component and we need to use dropDown instead main button

At the moment there are no tests in the repository, but once they're added, we should write some basic tests for the Notifications components.

We need to activate docs tab in storybook. It should contain the README files

Right now the AdaptiveTabs component doesn't have the qa props. This makes e2e tests harder to maintain when the component involved.

TODO in the next major.

1. Let's change wrapTo interface. I suggest this one
   (node, {tab: TabItem | undefined; tabIndex: number | undefined}: RenderOptions) => React.ReactNode

2. Also let's add return tab when render switcher as standalone select. For more select it looks like useless because when user select something in more it will be rendered directly to the left of the selector.

We had this logic earlier in case:

• click on "more" (list of more items opens)
• try to resize to small viewport
• expectation: list of more items closes; reality: list is still opened

Need to improve code here:
https://github.com/gravity-ui/components/blob/main/src/components/AdaptiveTabs/AdaptiveTabs.tsx#L857

Browsers provide default styles to generate a password in the new-password type input. If the user agrees, the browser add yellow background to the input. Safari hides part of the generated password at the same time

Suggestion

1. Remove the yellow background at all.
2. By default, leave the standard behavior in the browser - suggestions to generate a password
3. If we display the Generate password button, we disable the browser offer to generate a password

Current behavior

Suggested behavior

Note

need to check in all major browsers and OS
An example of an input with the proposed behavior: https://github.com/signup
source: https://github.com/gravity-ui/components/tree/main/src/components/PasswordInput

The component should start using Tabs component from gravity-ui/uikit instead of own Tabs.
DATAUI-1524

How to reproduce

• Go to the InfiniteScroll story
• Don't scroll
• Look carefully at the scrollbar

Expected

InfiniteScroll calls onActivate once and loads the items exactly once.

Got instead

InfiniteScroll calls onActivate twice so we load more items than expected (20 instead of 10).

Add the ability to set a footer component for the table. It can be sticky or non-sticky.

Page of component ItemSelector has error
https://preview.gravity-ui.com/components/?path=/story/components-itemselector--default

TypeError: Cannot destructure property 'getCurrentStoryData' of 'useStorybookApi(...)' as it is undefined.
    at useArgs (https://preview.gravity-ui.com/components/5707.5e10e992.iframe.bundle.js:19:40578)

When passing wrapTo like:
(item, node) => <Wrapper><Icon />{node}<Icon2 /></Wrapper>

I'm expecting this:

But getting this:

Problems:

1. Blue line is only under the node, not under the tab container
2. Part of wrapped node is in hidden area because of node itself has no text overflow property.