window[LOADABLE_STATE] is not working about loadable-components HOT 4 CLOSED

@neoziro I think I found a possible solution:
basically I change the loadComponents() to this:

function loadComponents() {

  if (typeof window === 'undefined') {
throw new Error('loadable-components: loadComponents must be called client-side: window is undefined');
 }   
  return new Promise(function (resolve, reject) {
    window.onload = function() {
      var state = window[LOADABLE_STATE];
      if (!state) {
        throw new Error('loadable-components state not found. ' + 'You have a problem server-side. ' + 'Please verify that you have called `loadableState.getScriptTag()` server-side.');
      }
      resolve(loadState(state));
    }
  });
}

The function has to wait for the window to be fully loaded and then I have to wrap it in a Promise, in order to return only when the window is loaded.

Do you think this is a bug or do you think I might missing something somewhere?

from loadable-components.

Ah good workaround. In fact loadableState.getScriptTag() must be called before your loadComponents() and it should work without having to rewrite the loadComponents method.

from loadable-components.

Thanks for the reply, I moved the loadableState.getScriptTag() before importing my main js file and it is working now. By the way, I'm not 100% sure the window is gonna be loaded every time, do you think might be useful to wrap it on a promise and wait for onload event before resolving the promise?

from loadable-components.

No I don't think so. You should add scripts at the end of the body, this is the way to setup all React stuff so I think it is OK like that.

from loadable-components.